-
Notifications
You must be signed in to change notification settings - Fork 66
Additional Presets #1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Presets #1538
Conversation
|
@vsevel if you use your own implementation of code.quarkus, then you may now override some platform data (including presets). |
|
I definitely want to try that. Any référence documentation available @ia3andy ? |
|
I am confused. the ability to have custom presets is not directly supported in the community code quarkus app (which is what we are using today)? |
Ok, I didn't remember if you where using the community image or your own custom. We might be able to make it configurable in the community image like you did in this PR |
that would be great |
|
@vsevel could you update your PR to make the list optional and replace the default in case it's present? |
# Conflicts: # base/src/main/java/io/quarkus/code/rest/CodeQuarkusResource.java
cd22831 to
1feecd1
Compare
my intent was to append my presets, not replace the existing ones I rebased and pushed |
|
hello @ia3andy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
we have deployed the last released image, and I can confirm custom presets work as expected. |
Provides the ability to express additional presets in configuration
Fixes #1480
The current approach is to keep the default presets as a constant, and to allow defining more presets in configuration.
This allows appending presets to the existing one, and not just replace them.
If we want to move the
PRESETSconstant to configuration, then we would need 2 config variablespresetsandadditional-presets.see also this zulip thread.
cc @ia3andy