[Olmo2]: Add Support for Olmo2 CausalLM Model in QEff #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perplexity is verified. Thanks @tchawada 
|
quic-hemagnih
approved these changes
Sep 5, 2025
quic-rishinr
approved these changes
Sep 16, 2025
vbaddi
force-pushed
the
add_olmo2
branch
3 times, most recently
from
dbf736c to
82de9ac
Compare
abukhoy
reviewed
Sep 30, 2025
Signed-off-by: vbaddi <[email protected]>
abukhoy
reviewed
Oct 3, 2025
| ) | ||
| assert (pytorch_hf_tokens == pytorch_kv_tokens).all(), ( | ||
| "Tokens don't match for HF PyTorch model output and KV PyTorch model output" | ||
| ) |
There was a problem hiding this comment.
Please remove this check also, as you can see, we are checking the same in the if condition above for non-swiftkv models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.