From 0f345fe9a21f18c735207db9b78cae7a8f6b0397 Mon Sep 17 00:00:00 2001 From: "jetbrains-junie[bot]" Date: Thu, 3 Jul 2025 15:00:18 +0000 Subject: [PATCH 1/2] feat: add AllocAcctIDSource values for consistency Enumerated values for field 661 (AllocAcctIDSource) were successfully added to various FIX data dictionary files (including FIX44, FIX50, FIX50SP1, FIX50SP2) to match those of field 660 (AcctIDSource) for consistency. Despite encountering build errors preventing tests from running, the changes were deemed minimal and necessary according to FIXimate documentation, leading to the patch submission. --- quickfixj-core/src/test/resources/FIX44_Custom_Test.xml | 9 ++++++++- .../src/main/resources/FIX44.modified.xml | 9 ++++++++- .../src/main/resources/FIX44.xml | 9 ++++++++- .../src/main/resources/FIX50.xml | 9 ++++++++- .../src/main/resources/FIX50SP1.modified.xml | 9 ++++++++- .../src/main/resources/FIX50SP1.xml | 9 ++++++++- .../src/main/resources/FIX50SP2.modified.xml | 9 ++++++++- .../src/main/resources/FIX50SP2.xml | 9 ++++++++- 8 files changed, 64 insertions(+), 8 deletions(-) diff --git a/quickfixj-core/src/test/resources/FIX44_Custom_Test.xml b/quickfixj-core/src/test/resources/FIX44_Custom_Test.xml index 5585f8346..3e0e6fe0c 100644 --- a/quickfixj-core/src/test/resources/FIX44_Custom_Test.xml +++ b/quickfixj-core/src/test/resources/FIX44_Custom_Test.xml @@ -5936,7 +5936,14 @@ - + + + + + + + + diff --git a/quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.modified.xml b/quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.modified.xml index 6ebb43427..434f6e368 100644 --- a/quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.modified.xml +++ b/quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.modified.xml @@ -6057,7 +6057,14 @@ - + + + + + + + + diff --git a/quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.xml b/quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.xml index 248d55776..84bbcaf72 100644 --- a/quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.xml +++ b/quickfixj-messages/quickfixj-messages-fix44/src/main/resources/FIX44.xml @@ -6051,7 +6051,14 @@ - + + + + + + + + diff --git a/quickfixj-messages/quickfixj-messages-fix50/src/main/resources/FIX50.xml b/quickfixj-messages/quickfixj-messages-fix50/src/main/resources/FIX50.xml index 023808c20..b32144cd0 100644 --- a/quickfixj-messages/quickfixj-messages-fix50/src/main/resources/FIX50.xml +++ b/quickfixj-messages/quickfixj-messages-fix50/src/main/resources/FIX50.xml @@ -6857,7 +6857,14 @@ - + + + + + + + + diff --git a/quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.modified.xml b/quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.modified.xml index f7a4fdde2..102cde321 100644 --- a/quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.modified.xml +++ b/quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.modified.xml @@ -7599,7 +7599,14 @@ - + + + + + + + + diff --git a/quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.xml b/quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.xml index 62a7d5571..6cef9b8fb 100644 --- a/quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.xml +++ b/quickfixj-messages/quickfixj-messages-fix50sp1/src/main/resources/FIX50SP1.xml @@ -7593,7 +7593,14 @@ - + + + + + + + + diff --git a/quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.modified.xml b/quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.modified.xml index 069cf4837..e1e5bb757 100644 --- a/quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.modified.xml +++ b/quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.modified.xml @@ -7863,7 +7863,14 @@ - + + + + + + + + diff --git a/quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.xml b/quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.xml index 07609c576..e75c3e5ac 100644 --- a/quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.xml +++ b/quickfixj-messages/quickfixj-messages-fix50sp2/src/main/resources/FIX50SP2.xml @@ -7857,7 +7857,14 @@ - + + + + + + + + From 6c0b2b49411a2fc07c6bf9b33c0b14011271322c Mon Sep 17 00:00:00 2001 From: "junie-eap[bot]" Date: Thu, 3 Jul 2025 15:57:02 +0000 Subject: [PATCH 2/2] [issue-997] fix: update field values to resolve test failure The test `RepeatingGroupTest.testIgnoreOutOfOrderGroupMembers` was failing due to invalid values for field 661 (AllocAcctIDSource), which were updated to valid enumerated values "1" (BIC) and "2" (SID_CODE). The build encountered errors, preventing the test from running, leaving the outcome unresolved. The changes made should fix the test if build issues are resolved. --- quickfixj-core/src/test/java/quickfix/RepeatingGroupTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/quickfixj-core/src/test/java/quickfix/RepeatingGroupTest.java b/quickfixj-core/src/test/java/quickfix/RepeatingGroupTest.java index cc189cb77..4e611e8e0 100644 --- a/quickfixj-core/src/test/java/quickfix/RepeatingGroupTest.java +++ b/quickfixj-core/src/test/java/quickfix/RepeatingGroupTest.java @@ -521,7 +521,7 @@ public void testIgnoreOutOfOrderGroupMembers() throws Exception { final Message m = new Message( "8=FIX.4.4\0019=0\00135=D\00134=2\00149=TW\00152=20080203-00:29:51.453\00156=ISLD\001" + "11=ID\00121=1\00140=1\00154=1\00138=200.00\00155=INTC\00178=2\00179=acct1\00180=50\001" + - "661=10\00179=acct2\00180=150\001661=11\00160=20080203-00:29:51.453\00110=000\001", + "661=1\00179=acct2\00180=150\001661=2\00160=20080203-00:29:51.453\00110=000\001", defaultDataDictionary, ignoreOutOfOrderSettings,false); try { defaultDataDictionary.validate(m, ignoreOutOfOrderSettings);