refactor (#54)

Signed-off-by: Gabriele Santomaggio <[email protected]>

Author: Gsantomaggio

pkg/rabbitmqamqp/amqp_binding.go

@@ -10,12 +10,12 @@ type AMQPBindingInfo struct {
 }
 
 type AMQPBinding struct {
-	sourceName          string
-	destinationName     string
-	toQueue             bool
-	bindingKey          string
-	management          *AmqpManagement
-	additionalArguments map[string]any
+	sourceName      string
+	destinationName string
+	toQueue         bool
+	bindingKey      string
+	management      *AmqpManagement
+	arguments       map[string]any
 }
 
 func newAMQPBinding(management *AmqpManagement) *AMQPBinding {
@@ -38,8 +38,8 @@ func (b *AMQPBinding) Destination(name string, isQueue bool) {
 	b.toQueue = isQueue
 }
 
-func (b *AMQPBinding) AdditionalArguments(args map[string]any) {
-	b.additionalArguments = args
+func (b *AMQPBinding) Arguments(arguments map[string]any) {
+	b.arguments = arguments
 }
 
 // Bind creates a binding between an exchange and a queue or exchange
@@ -61,8 +61,8 @@ func (b *AMQPBinding) Bind(ctx context.Context) (string, error) {
 	kv["binding_key"] = b.bindingKey
 	kv["source"] = b.sourceName
 	kv[destination] = b.destinationName
-	if b.additionalArguments != nil {
-		kv["arguments"] = b.additionalArguments
+	if b.arguments != nil {
+		kv["arguments"] = b.arguments
 	} else {
 		kv["arguments"] = make(map[string]any)
 	}

pkg/rabbitmqamqp/amqp_binding_test.go

@@ -69,6 +69,7 @@ var _ = Describe("AMQP Bindings test ", func() {
 		bindingPath, err := management.Bind(context.TODO(), &ExchangeToExchangeBindingSpecification{
 			SourceExchange:      exchangeName,
 			DestinationExchange: exchangeName2,
+			Arguments:           map[string]any{},
 		})
 
 		Expect(err).To(BeNil())
@@ -82,27 +83,31 @@ var _ = Describe("AMQP Bindings test ", func() {
 		_, err := management.Bind(context.TODO(), &ExchangeToExchangeBindingSpecification{
 			SourceExchange:      "",
 			DestinationExchange: "destination",
+			Arguments:           map[string]any{},
 		})
 		Expect(err).NotTo(BeNil())
 		Expect(err.Error()).To(ContainSubstring("source and destination names are required"))
 
 		_, err = management.Bind(context.TODO(), &ExchangeToExchangeBindingSpecification{
 			SourceExchange:      "source",
 			DestinationExchange: "",
+			Arguments:           map[string]any{},
 		})
 		Expect(err).NotTo(BeNil())
 		Expect(err.Error()).To(ContainSubstring("source and destination names are required"))
 
 		_, err = management.Bind(context.TODO(), &ExchangeToQueueBindingSpecification{
 			SourceExchange:   "",
 			DestinationQueue: "destination",
+			Arguments:        map[string]any{},
 		})
 		Expect(err).NotTo(BeNil())
 		Expect(err.Error()).To(ContainSubstring("source and destination names are required"))
 
 		_, err = management.Bind(context.TODO(), &ExchangeToQueueBindingSpecification{
 			SourceExchange:   "source",
 			DestinationQueue: "",
+			Arguments:        map[string]any{"binding_key": "key"},
 		})
 		Expect(err).NotTo(BeNil())
 		Expect(err.Error()).To(ContainSubstring("source and destination names are required"))

pkg/rabbitmqamqp/amqp_management.go

@@ -182,7 +182,7 @@ func (a *AmqpManagement) DeclareQueue(ctx context.Context, specification IQueueS
 	amqpQueue.AutoDelete(specification.isAutoDelete())
 	amqpQueue.Exclusive(specification.isExclusive())
 	amqpQueue.QueueType(specification.queueType())
-	amqpQueue.SetArguments(specification.buildArguments())
+	amqpQueue.Arguments(specification.buildArguments())
 
 	return amqpQueue.Declare(ctx)
 }
@@ -217,7 +217,7 @@ func (a *AmqpManagement) Bind(ctx context.Context, bindingSpecification IBinding
 	bind.SourceExchange(bindingSpecification.sourceExchange())
 	bind.Destination(bindingSpecification.destination(), bindingSpecification.isDestinationQueue())
 	bind.BindingKey(bindingSpecification.bindingKey())
-	bind.AdditionalArguments(bindingSpecification.arguments())
+	bind.Arguments(bindingSpecification.arguments())
 	return bind.Bind(ctx)
 
 }

pkg/rabbitmqamqp/amqp_queue.go

@@ -88,7 +88,7 @@ type AmqpQueue struct {
 	name         string
 }
 
-func (a *AmqpQueue) SetArguments(arguments map[string]any) {
+func (a *AmqpQueue) Arguments(arguments map[string]any) {
 	a.arguments = arguments
 }