Skip to content

Commit 3dd3b69

Browse files
Merge pull request #10586 from rabbitmq/qq-file-handle-reservation-defensiveness
QQ: be more defensive when reserving file handles.
2 parents 657a5b7 + 85d5aed commit 3dd3b69

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

deps/rabbit/src/rabbit_quorum_queue.erl

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1396,9 +1396,16 @@ is_match(Subj, E) ->
13961396
nomatch /= re:run(Subj, E).
13971397

13981398
file_handle_leader_reservation(QName) ->
1399-
{ok, Q} = rabbit_amqqueue:lookup(QName),
1400-
ClusterSize = length(get_nodes(Q)),
1401-
file_handle_cache:set_reservation(2 + ClusterSize).
1399+
try
1400+
{ok, Q} = rabbit_amqqueue:lookup(QName),
1401+
ClusterSize = length(get_nodes(Q)),
1402+
file_handle_cache:set_reservation(2 + ClusterSize)
1403+
catch Class:Err ->
1404+
rabbit_log:warning("~s:~s/~b failed with ~w ~w",
1405+
[?MODULE, ?FUNCTION_NAME, ?FUNCTION_ARITY,
1406+
Class, Err])
1407+
end.
1408+
14021409

14031410
file_handle_other_reservation() ->
14041411
file_handle_cache:set_reservation(2).

0 commit comments

Comments
 (0)