correct the 'is this varref deeper than its binding?' predicate

Author: rfindler

drracket-tool-test/tests/check-syntax/syncheck-direct.rkt

@@ -453,6 +453,36 @@
   '((28 39) (50 50))))
 
 
+(check-equal?
+ (get-binding-arrows
+  (string-append
+   "#lang racket/base\n"
+   "(module m racket/base\n"
+   "  (define lam 1)\n"
+   "  (provide lam)\n"
+   "  lam)\n"))
+ (set '((6 17) (19 25))
+      '((28 39) (43 49))
+      '((28 39) (54 54))
+      '((28 39) (60 67))
+      '((50 53) (75 78))
+      '((50 53) (68 71))))
+
+(check-equal?
+ (get-binding-arrows
+  (string-append
+   "#lang racket/base\n"
+   "(module m racket/base\n"
+   "  (define lam 1)\n"
+   "  (module+ n (provide lam)))\n"))
+ (set '((6 17) (19 25))
+      '((28 39) (43 49))
+      '((28 39) (54 54))
+      '((28 39) (60 67))
+      '((28 39) (71 78))
+      '((50 53) (79 82))))
+
+
 
 ;                                                       
 ;                                                       

drracket-tool-text-lib/drracket/private/syncheck/traversals.rkt

@@ -919,12 +919,13 @@
             (let loop ([mods-where-var-is (reverse mods-where-var-is)]
                        [mods-where-binder-is (reverse (binder+mods-mods binder+mods))])
               (cond
-                [(null? mods-where-binder-is) #t]
+                [(null? mods-where-binder-is)
+                 (for/and ([mod (in-list mods-where-var-is)])
+                   (submodule-enclosing-bindings-visible? mod))]
                 [(null? mods-where-var-is) #f]
                 [else
-                 (define mod (car mods-where-var-is))
-                 (and (submodule-enclosing-bindings-visible? mod)
-                      (equal? mod (car mods-where-binder-is))
+                 (and (equal? (car mods-where-var-is)
+                              (car mods-where-binder-is))
                       (loop (cdr mods-where-var-is)
                             (cdr mods-where-binder-is)))]))))
       (when binder-is-outside-reference?