Skip to content

Add missing executor core limit flag to app deployer #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add missing executor core limit flag to app deployer #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d505ab6
Add missing executor core limit flag to app deployer
Oct 10, 2019
721e63b
Decrease example's executor core limit from 400m to 200m
sinabakh Jan 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ spec:
executor:
instances: 2
cores: 1
coreLimit: 400m
coreLimit: 200m
labels:
foo: bar
1 change: 1 addition & 0 deletions src/main/java/io/radanalytics/operator/app/KubernetesAppDeployer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ private ReplicationController getSubmitterRc(SparkApplication app, String namesp
command.append(" --conf spark.kubernetes.submission.waitAppCompletion=false");
command.append(" --conf spark.driver.cores=").append(driver.getCores());
command.append(" --conf spark.kubernetes.driver.limit.cores=").append(driver.getCoreLimit());
command.append(" --conf spark.kubernetes.executor.limit.cores=").append(executor.getCoreLimit());
command.append(" --conf spark.driver.memory=").append(driver.getMemory());
if (driver.getMemoryOverhead() != null) {
command.append(" --conf spark.driver.memoryOverhead=").append(driver.getMemoryOverhead());
Expand Down