Skip to content

Commit 1d56bf7

Browse files
committed
Remove approval block to run tests, lint, and annotations
These steps are designed so any code executed from the workspace happens inside an unprivileged docker container. We would get faster feedback on PRs if these run instantly.
1 parent 13b395c commit 1d56bf7

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

pipelines/buildkite-config/initial.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,6 @@
44
# This config is intended for running the rails/buildkite-config CI.
55

66
steps:
7-
- block: "Review Build Script"
8-
branches: "!main"
9-
prompt: |
10-
Our CI scripts run outside the docker containers, which are a necessary security layer.
11-
12-
Approving a build here is equivalent to copy & pasting it into a production ssh window.
13-
14-
Prefer a second opinion for any nontrivial change, especially outside `pipeline-generate`.
15-
16-
- @matthewd
177
- group:
188
label: ":pipeline: buildkite-config meta-ci"
199
key: "meta"

0 commit comments

Comments
 (0)