From e94ca1795a42086567dce26c4b86acd4b0813c2e Mon Sep 17 00:00:00 2001 From: Bhumi Shah Date: Mon, 21 Apr 2025 13:39:17 -0500 Subject: [PATCH 1/7] fix h1 on index page --- index.html | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/index.html b/index.html index af3dac96f..4f82a8960 100644 --- a/index.html +++ b/index.html @@ -36,7 +36,7 @@

Learn just what you need to get started, then keep leveling up as you go.
-

You’re in good company.

+

You’re in good company.

Over the past two decades, Rails has taken countless companies to millions of users and billions in market valuations.

@@ -164,7 +164,7 @@

Over the past two decades, Rails has taken countless companies to millions o
-

Building it together.

+

Building it together.

Over six thousand people have contributed code to Rails, and many more have served the community through evangelism, documentation, and bug reports. Join us!

@@ -180,7 +180,7 @@

Over six thousand people have
-

Everything you need.

+

Everything you need.

Rails is a full-stack framework. It ships with all the tools needed to build amazing web apps on both the front and back end.

@@ -307,7 +307,7 @@

Action Dispatch routes URLs.

-

Optimized for happiness.

+

Optimized for happiness.

@@ -325,7 +325,7 @@

Optimized for happiness.

-

Let’s get started.

+

Let’s get started.

From 0d2909b23e190064643d4749981866d9d8ce9dbc Mon Sep 17 00:00:00 2001 From: Bhumi Shah Date: Mon, 21 Apr 2025 14:21:06 -0500 Subject: [PATCH 2/7] add or update h1 --- _pages/community.html | 2 +- blog/index.html | 12 ++++++++++++ world/2025/index.html | 3 ++- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/_pages/community.html b/_pages/community.html index 0cfd38281..e606001b7 100644 --- a/_pages/community.html +++ b/_pages/community.html @@ -10,7 +10,7 @@
-

We make Rails better.

+

The community makes Rails better.

Rails is improving every year from the work of thousands of volunteers contributing in ways big and small. Everyone can help make this framework better whether they’ve been using it since the beginning or they just started yesterday.

diff --git a/blog/index.html b/blog/index.html index 199c0e59a..4c1873bc9 100644 --- a/blog/index.html +++ b/blog/index.html @@ -3,6 +3,18 @@ description: --- +
+
+
+
+

+ Ruby on Rails News +

+
+
+
+
+
diff --git a/world/2025/index.html b/world/2025/index.html index 638cc6c11..86ff97198 100644 --- a/world/2025/index.html +++ b/world/2025/index.html @@ -7,7 +7,8 @@
Rails World 2025 Square Logo -

September 4 & 5

+

Rails World 2025

+

September 4 & 5

Beurs van Berlage, Amsterdam

From 879f47d4852f1c8424eb25c090cad51989b7454f Mon Sep 17 00:00:00 2001 From: Bhumi Shah Date: Fri, 16 May 2025 10:59:01 -0500 Subject: [PATCH 3/7] keep h1 styles for h2 elements on home page --- _layouts/default.html | 2 +- _sass/common/_headline.scss | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/_layouts/default.html b/_layouts/default.html index 4c2ad2503..bd97ef75f 100755 --- a/_layouts/default.html +++ b/_layouts/default.html @@ -3,7 +3,7 @@ {% include head.html %} - + {% include notification.html %} {% if page.id == 'home' %} {% include banner.html %} diff --git a/_sass/common/_headline.scss b/_sass/common/_headline.scss index b80cb5312..3a839877f 100755 --- a/_sass/common/_headline.scss +++ b/_sass/common/_headline.scss @@ -116,6 +116,13 @@ line-height: 44px; } + .page-home & { + h2 { + font-size: 78px; + line-height: 72px; + } + } + } From afc5e0ded0427d6c49a1b783f30d1d24227fdf09 Mon Sep 17 00:00:00 2001 From: Bhumi Shah Date: Tue, 20 May 2025 09:13:06 -0500 Subject: [PATCH 4/7] update h2 styles to micic h1 on home --- _sass/common/_headline.scss | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/_sass/common/_headline.scss b/_sass/common/_headline.scss index 3a839877f..a61edccc7 100755 --- a/_sass/common/_headline.scss +++ b/_sass/common/_headline.scss @@ -118,8 +118,11 @@ .page-home & { h2 { - font-size: 78px; - line-height: 72px; + color: $color-red; + font-size: 47px; + font-weight: 700; + letter-spacing: -0.01em; + line-height: 43px; } } From 969c56801df44ce7fd7b2cf907813d8277fb50ee Mon Sep 17 00:00:00 2001 From: bhumi1102 Date: Tue, 20 May 2025 09:24:21 -0500 Subject: [PATCH 5/7] Apply suggestions from code review Co-authored-by: Amanda Perino <58528404+AmandaPerino@users.noreply.github.com> --- _pages/community.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_pages/community.html b/_pages/community.html index e606001b7..0cfd38281 100644 --- a/_pages/community.html +++ b/_pages/community.html @@ -10,7 +10,7 @@
-

The community makes Rails better.

+

We make Rails better.

Rails is improving every year from the work of thousands of volunteers contributing in ways big and small. Everyone can help make this framework better whether they’ve been using it since the beginning or they just started yesterday.

From 4f99812ef264b9b15c89eecd34013ceb7f634360 Mon Sep 17 00:00:00 2001 From: Bhumi Shah Date: Thu, 29 May 2025 11:11:58 -0500 Subject: [PATCH 6/7] copy h1 styles for all media sizes --- _sass/common/_headline.scss | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/_sass/common/_headline.scss b/_sass/common/_headline.scss index a61edccc7..0cba581b1 100755 --- a/_sass/common/_headline.scss +++ b/_sass/common/_headline.scss @@ -63,6 +63,16 @@ line-height: 26px; } + .page-home & { + h2 { + color: $color-red; + font-size: 47px; + font-weight: 700; + letter-spacing: -0.01em; + line-height: 43px; + } + } + a { color: $color-black; @@ -88,8 +98,6 @@ font-weight: 600; } - - @media(min-width: 1024px) { font-size: 21px; @@ -118,11 +126,8 @@ .page-home & { h2 { - color: $color-red; - font-size: 47px; - font-weight: 700; - letter-spacing: -0.01em; - line-height: 43px; + font-size: 78px; + line-height: 72px; } } From 40db60c060787a6351fa1ac13e5286233d94c095 Mon Sep 17 00:00:00 2001 From: Bhumi Shah Date: Mon, 9 Jun 2025 08:36:24 -0500 Subject: [PATCH 7/7] add Docs to h1 per review comment --- _pages/docs.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_pages/docs.html b/_pages/docs.html index 83a58f12e..622a91072 100644 --- a/_pages/docs.html +++ b/_pages/docs.html @@ -11,7 +11,7 @@

- Everything you need
to get building. + Docs: Everything you need
to get building.