Fix Windows build and CI with libusb (#253)

* Fix Windows build

* Fix Windows LibUSB in CI

* Add test that libusb has been included

Author: will-v-pi

.github/workflows/test.yml

@@ -31,10 +31,15 @@ jobs:
           choco install -y .github/workflows/choco_packages.config
           curl -L https://github.com/libusb/libusb/releases/download/v1.0.27/libusb-1.0.27.7z -o libusb.7z
           7z x libusb.7z -olibusb
+          ls libusb
       - name: Set LIBUSB_ROOT (Windows)
         if: runner.os == 'Windows'
-        shell: bash
-        run: echo "LIBUSB_ROOT=$(pwd)/libusb" >> "$GITHUB_ENV"
+        run: |
+          "LIBUSB_ROOT=$(pwd)/libusb" >> $env:GITHUB_ENV
+      - name: Check LIBUSB_ROOT (Windows)
+        if: runner.os == 'Windows'
+        run: |
+          echo $env:LIBUSB_ROOT
 
       - name: Install dependencies (macOS)
         if: runner.os == 'macOS'
@@ -71,6 +76,13 @@ jobs:
           picotool info -a blink.uf2
           picotool info -a hello_world.uf2
           picotool info -a flash_nuke.uf2
+      
+      - name: Test libusb compiled
+        if: matrix.libusb == 'libusb'
+        run: |
+          picotool help load
+          picotool help save
+          picotool help erase
 
   test-examples:
     # Prevent running twice for PRs from same repo

picoboot_connection/picoboot_connection_cxx.cpp

@@ -10,6 +10,13 @@
 #include <algorithm>
 #include "picoboot_connection_cxx.h"
 
+#ifdef _WIN32
+#undef min
+#undef max
+
+#define _CRT_SECURE_NO_WARNINGS
+#endif
+
 using picoboot::connection;
 using picoboot::connection_error;
 using picoboot::command_failure;