RDBC-959: AiCS methods modified to package-private

Author: LielNagar

src/main/java/net/ravendb/client/documents/AI/AiConversationCreationOptions.java

@@ -10,6 +10,10 @@ public class AiConversationCreationOptions {
     public AiConversationCreationOptions() {
     }
 
+    public AiConversationCreationOptions(Map<String, Object> parameters) {
+        this(parameters, null);
+    }
+
     public AiConversationCreationOptions(Map<String, Object> parameters, Integer expirationInSec) {
         this.parameters = parameters;
         this.expirationInSec = expirationInSec;

src/main/java/net/ravendb/client/documents/operations/AI/AiConnectionString.java

@@ -216,7 +216,7 @@ public boolean isEqual(ConnectionString other) {
         return diffs.isEmpty() || (diffs.size() == 1 && diffs.contains(AiSettingsCompareDifferences.None));
     }
 
-    public boolean usingEncryptedCommunicationChannel() {
+    boolean usingEncryptedCommunicationChannel() {
         AiConnectorType type = getActiveProvider();
 
         switch (type) {
@@ -245,7 +245,7 @@ public boolean usingEncryptedCommunicationChannel() {
         }
     }
 
-    public int getQueryEmbeddingsMaxConcurrentBatches(int globalDefault) {
+    int getQueryEmbeddingsMaxConcurrentBatches(int globalDefault) {
         AbstractAiSettings provider = getActiveProviderInstance();
         return provider != null && provider.getEmbeddingsMaxConcurrentBatches() != null
                 ? provider.getEmbeddingsMaxConcurrentBatches()

src/test/java/net/ravendb/client/documents/operations/ConnectionStringsTest.java

@@ -16,6 +16,8 @@
 import net.ravendb.client.serverwide.ConnectionStringType;
 import net.ravendb.client.documents.operations.etl.RavenConnectionString;
 import org.junit.jupiter.api.Test;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
 import java.util.EnumSet;
 import java.util.List;
 
@@ -633,36 +635,45 @@ public void isEqualReturnsFalseForDifferentNames() {
 
     @EnableOnServer(thresholdVersion = "7.1")
     @Test
-    public void usingEncryptedCommunicationChannelDetectsHttps() {
+    public void usingEncryptedCommunicationChannelDetectsHttps() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException {
         OpenAiSettings openAiSettings = new OpenAiSettings();
         openAiSettings.setApiKey("key");
         openAiSettings.setEndpoint("https://api.openai.com/");
         openAiSettings.setModel("model");
 
         AiConnectionString cs1 = new AiConnectionString();
         cs1.setOpenAiSettings(openAiSettings);
-        assertThat(cs1.usingEncryptedCommunicationChannel()).isTrue();
+        Method method = AiConnectionString.class.getDeclaredMethod("usingEncryptedCommunicationChannel");
+        method.setAccessible(true);
+        boolean result = (boolean) method.invoke(cs1);
+        assertThat(result).isTrue();
 
         OllamaSettings ollamaSettings1 = new OllamaSettings();
         ollamaSettings1.setUri("http://localhost:11434");
         ollamaSettings1.setModel("llama2");
 
         AiConnectionString cs2 = new AiConnectionString();
         cs2.setOllamaSettings(ollamaSettings1);
-        assertThat(cs2.usingEncryptedCommunicationChannel()).isFalse();
+        Method method2 = AiConnectionString.class.getDeclaredMethod("usingEncryptedCommunicationChannel");
+        method2.setAccessible(true);
+        boolean result2 = (boolean) method.invoke(cs2);
+        assertThat(result2).isFalse();
 
         OllamaSettings ollamaSettings2 = new OllamaSettings();
         ollamaSettings2.setUri("https://secure-ollama.com");
         ollamaSettings2.setModel("llama2");
 
         AiConnectionString cs3 = new AiConnectionString();
         cs3.setOllamaSettings(ollamaSettings2);
-        assertThat(cs3.usingEncryptedCommunicationChannel()).isTrue();
+        Method method3 = AiConnectionString.class.getDeclaredMethod("usingEncryptedCommunicationChannel");
+        method3.setAccessible(true);
+        boolean result3 = (boolean) method.invoke(cs3);
+        assertThat(result3).isTrue();
     }
 
     @EnableOnServer(thresholdVersion = "7.1")
     @Test
-    public void getQueryEmbeddingsMaxConcurrentBatchesUsesProviderValue() {
+    public void getQueryEmbeddingsMaxConcurrentBatchesUsesProviderValue() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException {
         OpenAiSettings settings = new OpenAiSettings();
         settings.setApiKey("key");
         settings.setEndpoint("https://api.openai.com/");
@@ -671,13 +682,15 @@ public void getQueryEmbeddingsMaxConcurrentBatchesUsesProviderValue() {
 
         AiConnectionString cs = new AiConnectionString();
         cs.setOpenAiSettings(settings);
-
-        assertThat(cs.getQueryEmbeddingsMaxConcurrentBatches(10)).isEqualTo(5);
+        Method method = AiConnectionString.class.getDeclaredMethod("getQueryEmbeddingsMaxConcurrentBatches", int.class);
+        method.setAccessible(true);
+        int result = (int) method.invoke(cs, 10);
+        assertThat(result).isEqualTo(5);
     }
 
     @EnableOnServer(thresholdVersion = "7.1")
     @Test
-    public void getQueryEmbeddingsMaxConcurrentBatchesUsesGlobalValueWhenNotSet() {
+    public void getQueryEmbeddingsMaxConcurrentBatchesUsesGlobalValueWhenNotSet() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException {
         OpenAiSettings settings = new OpenAiSettings();
         settings.setApiKey("key");
         settings.setEndpoint("https://api.openai.com/");
@@ -686,7 +699,10 @@ public void getQueryEmbeddingsMaxConcurrentBatchesUsesGlobalValueWhenNotSet() {
         cs.setOpenAiSettings(settings);
 
         int fallbackValue = 10;
-        assertThat(cs.getQueryEmbeddingsMaxConcurrentBatches(fallbackValue)).isEqualTo(10);
+        Method method = AiConnectionString.class.getDeclaredMethod("getQueryEmbeddingsMaxConcurrentBatches");
+        method.setAccessible(true);
+        int result = (int) method.invoke(cs, fallbackValue);
+        assertThat(result).isEqualTo(10);
     }
 
     @EnableOnServer(thresholdVersion = "7.1")