RDBC-954 RemoveConnectionStringByNameOperation

Author: yh-0

ravendb/documents/operations/connection_string/remove_connection_string_by_name_operation.py

@@ -0,0 +1,57 @@
+import json
+import urllib
+from typing import Dict
+
+import requests
+
+from ravendb import RavenCommand, RaftCommand, ServerNode
+from ravendb.documents.operations.definitions import MaintenanceOperation
+from ravendb.util.util import RaftIdGenerator
+from ravendb.serverwide.server_operation_executor import ConnectionStringType
+
+
+class RemoveConnectionStringByNameResult:
+    def __init__(self, raft_command_index: int = None):
+        self.raft_command_index = raft_command_index
+
+    def to_json(self) -> Dict:
+        return {"RaftCommandIndex": self.raft_command_index}
+
+    @classmethod
+    def from_json(cls, json_dict: Dict) -> "RemoveConnectionStringResult":
+        return cls(json_dict["RaftCommandIndex"])
+
+
+class RemoveConnectionStringByNameOperation(MaintenanceOperation[RemoveConnectionStringByNameResult]):
+    def __init__(self, connection_string_name: str, connection_string_type: ConnectionStringType):
+        self._connection_string_name = connection_string_name
+        self._connection_string_type = connection_string_type
+
+    def get_command(self, conventions: "DocumentConventions") -> "RavenCommand[RemoveConnectionStringResult]":
+        return self.RemoveConnectionStringCommand(self._connection_string_name, self._connection_string_type)
+
+    class RemoveConnectionStringCommand(RavenCommand[RemoveConnectionStringByNameResult], RaftCommand):
+        def __init__(self, connection_string_name: str, connection_string_type: ConnectionStringType):
+            super().__init__(RemoveConnectionStringByNameResult)
+            self._connection_string_name = connection_string_name
+            self._connection_string_type = connection_string_type
+
+        def is_read_request(self) -> bool:
+            return False
+
+        def create_request(self, node: ServerNode) -> requests.Request:
+            url = f"{node.url}/databases/{node.database}/admin/connection-strings?connectionString={urllib.parse.quote(self._connection_string_name)}&type={self._connection_string_type.value}"
+
+            request = requests.Request("DELETE")
+            request.url = url
+
+            return request
+
+        def set_response(self, response: str, from_cache: bool) -> None:
+            if response is None:
+                self._throw_invalid_response()
+
+            self.result = RemoveConnectionStringByNameResult.from_json(json.loads(response))
+
+        def get_raft_unique_request_id(self) -> str:
+            return RaftIdGenerator.new_id()

ravendb/documents/operations/connection_string/remove_connection_string_operation.py

@@ -4,7 +4,7 @@
 
 import requests
 
-from ravendb import RavenCommand, RaftCommand, ServerNode
+from ravendb import RavenCommand, RaftCommand, ConnectionString, ServerNode
 from ravendb.documents.operations.definitions import MaintenanceOperation
 from ravendb.util.util import RaftIdGenerator
 from ravendb.serverwide.server_operation_executor import ConnectionStringType
@@ -23,24 +23,22 @@ def from_json(cls, json_dict: Dict) -> "RemoveConnectionStringResult":
 
 
 class RemoveConnectionStringOperation(MaintenanceOperation[RemoveConnectionStringResult]):
-    def __init__(self, connection_string_name: str, connection_string_type: ConnectionStringType):
-        self._connection_string_name = connection_string_name
-        self._connection_string_type = connection_string_type
+    def __init__(self, connection_string: ConnectionString = None):
+        self._connection_string = connection_string
 
     def get_command(self, conventions: "DocumentConventions") -> "RavenCommand[RemoveConnectionStringResult]":
-        return self.RemoveConnectionStringCommand(self._connection_string_name, self._connection_string_type)
+        return self.RemoveConnectionStringCommand(self._connection_string)
 
     class RemoveConnectionStringCommand(RavenCommand[RemoveConnectionStringResult], RaftCommand):
-        def __init__(self, connection_string_name: str, connection_string_type: ConnectionStringType):
+        def __init__(self, connection_string: ConnectionString = None):
             super().__init__(RemoveConnectionStringResult)
-            self._connection_string_name = connection_string_name
-            self._connection_string_type = connection_string_type
+            self._connection_string = connection_string
 
         def is_read_request(self) -> bool:
             return False
 
         def create_request(self, node: ServerNode) -> requests.Request:
-            url = f"{node.url}/databases/{node.database}/admin/connection-strings?connectionString={urllib.parse.quote(self._connection_string_name)}&type={self._connection_string_type.value}"
+            url = f"{node.url}/databases/{node.database}/admin/connection-strings?connectionString={urllib.parse.quote(self._connection_string.name)}&type={self._connection_string.get_type}"
 
             request = requests.Request("DELETE")
             request.url = url

ravendb/tests/jvm_migrated_tests/client_tests/documents_tests/operations_tests/test_connection_string.py

@@ -18,6 +18,8 @@
 from ravendb.documents.operations.connection_string.put_connection_string_operation import (
     PutConnectionStringOperation,
 )
+from ravendb.documents.operations.connection_string.remove_connection_string_by_name_operation import \
+    RemoveConnectionStringByNameOperation
 from ravendb.documents.operations.connection_string.remove_connection_string_operation import (
     RemoveConnectionStringOperation,
 )
@@ -84,7 +86,7 @@ def test_full_lifecycle_for_all_connection_string_types(self):
 
         # 3. Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("raven1", ConnectionStringType.RAVEN)
+            RemoveConnectionStringOperation(raven_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -103,7 +105,7 @@ def test_full_lifecycle_for_all_connection_string_types(self):
         self.assertEqual(1, len(sql_get_result.sql_connection_strings))
 
         # 3. Delete
-        remove_result = self.store.maintenance.send(RemoveConnectionStringOperation("sql1", ConnectionStringType.SQL))
+        remove_result = self.store.maintenance.send(RemoveConnectionStringOperation(sql_connection_string))
         self.assertGreater(remove_result.raft_command_index, 0)
 
         # 4. Get and Assert None
@@ -121,7 +123,7 @@ def test_full_lifecycle_for_all_connection_string_types(self):
         self.assertEqual(1, len(olap_get_result.olap_connection_strings))
 
         # 3. Delete
-        remove_result = self.store.maintenance.send(RemoveConnectionStringOperation("olap1", ConnectionStringType.OLAP))
+        remove_result = self.store.maintenance.send(RemoveConnectionStringOperation(olap_connection_string))
         self.assertGreater(remove_result.raft_command_index, 0)
 
         # 4. Get and Assert None
@@ -141,7 +143,7 @@ def test_full_lifecycle_for_all_connection_string_types(self):
 
         # 3. Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("elastic1", ConnectionStringType.ELASTIC_SEARCH)
+            RemoveConnectionStringOperation(elastic_search_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -165,7 +167,7 @@ def test_full_lifecycle_for_all_connection_string_types(self):
 
         # 3. Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("queue1", ConnectionStringType.QUEUE)
+            RemoveConnectionStringOperation(queue_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -187,7 +189,7 @@ def test_full_lifecycle_for_all_connection_string_types(self):
 
         # 3. Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("snowflake1", ConnectionStringType.SNOWFLAKE)
+            RemoveConnectionStringOperation(snowflake_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -208,7 +210,7 @@ def test_full_lifecycle_for_all_connection_string_types(self):
         self.assertEqual(1, len(ai_get_result.ai_connection_strings))
 
         # 3. Delete
-        remove_result = self.store.maintenance.send(RemoveConnectionStringOperation("ai1", ConnectionStringType.AI))
+        remove_result = self.store.maintenance.send(RemoveConnectionStringOperation(ai_connection_string))
         self.assertGreater(remove_result.raft_command_index, 0)
 
         # 4. Get and Assert None
@@ -238,7 +240,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("raven_all_fields", ConnectionStringType.RAVEN)
+            RemoveConnectionStringOperation(raven_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -272,7 +274,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("sql_all_fields", ConnectionStringType.SQL)
+            RemoveConnectionStringOperation(sql_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -468,7 +470,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("olap_all_fields", ConnectionStringType.OLAP)
+            RemoveConnectionStringOperation(olap_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -519,7 +521,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("ai_openai_chat", ConnectionStringType.AI)
+            RemoveConnectionStringOperation(ai_openai_chat_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -570,7 +572,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("ai_openai_embeddings", ConnectionStringType.AI)
+            RemoveConnectionStringOperation(ai_openai_embeddings_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -619,7 +621,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("ai_azure_openai", ConnectionStringType.AI)
+            RemoveConnectionStringOperation(ai_azure_openai_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -662,7 +664,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("ai_ollama", ConnectionStringType.AI)
+            RemoveConnectionStringOperation(ai_ollama_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -695,7 +697,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("ai_embedded", ConnectionStringType.AI)
+            RemoveConnectionStringOperation(ai_embedded_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -733,7 +735,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("ai_google", ConnectionStringType.AI)
+            RemoveConnectionStringOperation(ai_google_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -775,7 +777,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("ai_huggingface", ConnectionStringType.AI)
+            RemoveConnectionStringOperation(ai_huggingface_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -815,7 +817,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("ai_mistral", ConnectionStringType.AI)
+            RemoveConnectionStringOperation(ai_mistral_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -882,7 +884,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("elastic_all_fields", ConnectionStringType.ELASTIC_SEARCH)
+            RemoveConnectionStringOperation(elastic_search_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -1017,7 +1019,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("queue_all_fields", ConnectionStringType.QUEUE)
+            RemoveConnectionStringOperation(queue_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -1049,7 +1051,7 @@ def test_all_possible_fields_for_each_connection_string_type(self):
 
         # Delete
         remove_result = self.store.maintenance.send(
-            RemoveConnectionStringOperation("snowflake_all_fields", ConnectionStringType.SNOWFLAKE)
+            RemoveConnectionStringOperation(snowflake_connection_string)
         )
         self.assertGreater(remove_result.raft_command_index, 0)
 
@@ -1058,3 +1060,23 @@ def test_all_possible_fields_for_each_connection_string_type(self):
             GetConnectionStringsOperation("snowflake_all_fields", ConnectionStringType.SNOWFLAKE)
         )
         self.assertIsNone(after_delete.snowflake_connection_strings)
+
+    def test_remove_connection_string_by_name_operation(self):
+        raven_connection_string = RavenConnectionString("raven1", self.store.database, self.store.urls)
+
+        put_result = self.store.maintenance.send(PutConnectionStringOperation(raven_connection_string))
+        self.assertGreater(put_result.raft_command_index, 0)
+
+        raven_get_result = self.store.maintenance.send(
+            GetConnectionStringsOperation("raven1", ConnectionStringType.RAVEN)
+        )
+        self.assertIn("raven1", raven_get_result.raven_connection_strings)
+        self.assertEqual(1, len(raven_get_result.raven_connection_strings))
+
+        remove_result = self.store.maintenance.send(
+            RemoveConnectionStringByNameOperation("raven1", ConnectionStringType.RAVEN)
+        )
+        self.assertGreater(remove_result.raft_command_index, 0)
+
+        after_delete = self.store.maintenance.send(GetConnectionStringsOperation("raven1", ConnectionStringType.RAVEN))
+        self.assertIsNone(after_delete.raven_connection_strings)