Skip to content

Commit 70adaaa

Browse files
committed
RDBC-964 Fix SSLError in https test
1 parent 456675b commit 70adaaa

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/workflows/RavenClient.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
5555
- run: mkdir certs
5656
- run: openssl genrsa -out certs/ca.key 2048
57-
- run: openssl req -new -x509 -key certs/ca.key -out certs/ca.crt -subj "/C=US/ST=Arizona/L=Nevada/O=RavenDB Test CA/OU=RavenDB test CA/CN=localhost/[email protected]"
57+
- run: openssl req -new -x509 -key certs/ca.key -out certs/ca.crt -subj "/C=US/ST=Arizona/L=Nevada/O=RavenDB Test CA/OU=RavenDB test CA/CN=localhost/[email protected]" -addext "basicConstraints = critical,CA:TRUE" -addext "keyUsage = critical,digitalSignature,keyCertSign,cRLSign"
5858
- run: openssl genrsa -out certs/localhost.key 2048
5959
- run: openssl req -new -key certs/localhost.key -out certs/localhost.csr -subj "/C=US/ST=Arizona/L=Nevada/O=RavenDB Test/OU=RavenDB test/CN=localhost/[email protected]" -addext "subjectAltName = DNS:localhost"
6060
- run: openssl x509 -req -extensions ext -extfile cert/test_cert.conf -in certs/localhost.csr -CA certs/ca.crt -CAkey certs/ca.key -CAcreateserial -out certs/localhost.crt

ravendb/tests/jvm_migrated_tests/https_tests/test_https.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ def test_can_use_server_generated_certificate(self):
174174
tmp = tempfile.mkstemp()
175175
with open(tmp[1], "wb") as file:
176176
file.write(key[0].encode("utf-8"))
177+
file.write(b"\n")
177178
file.write(key[1])
178179
store_with_out_cert.certificate_pem_path = tmp[1]
179180
store_with_out_cert.initialize()
@@ -196,6 +197,7 @@ def test_should_throw_authorization_exception_when_not_autorized(self):
196197
tmp = tempfile.mkstemp()
197198
with open(tmp[1], "wb") as file:
198199
file.write(key.encode("utf-8"))
200+
file.write(b"\n")
199201
file.write(cert)
200202
store_wit_out_cert.certificate_pem_path = tmp[1]
201203
store_wit_out_cert.initialize()

0 commit comments

Comments
 (0)