Windows GitHub workers are way too flaky due to lag

Archmonger · Archmonger · commit 9ee027caf870 · 2026-02-15T19:08:57.000-08:00
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -15,7 +15,8 @@ jobs:
         uses: ./.github/workflows/.hatch-run.yml
         with:
             job-name: "python-{0}"
-            run-cmd: "hatch test --parallel --cover"
+            # Retries needed because GitHub workers sometimes lag enough to crash parallel workers
+            run-cmd: "hatch test --parallel --cover --retries 10"
     lint-python:
         uses: ./.github/workflows/.hatch-run.yml
         with:
@@ -25,7 +26,7 @@ jobs:
         uses: ./.github/workflows/.hatch-run.yml
         with:
             job-name: "python-{0} {1}"
-            run-cmd: "hatch test --parallel"
+            run-cmd: "hatch test --parallel --retries 10"
             runs-on: '["ubuntu-latest", "macos-latest", "windows-latest"]'
             python-version: '["3.11", "3.12", "3.13", "3.14"]'
     test-documentation:
diff --git a/tests/__init__.py b/tests/__init__.py
@@ -1,5 +0,0 @@
-import pytest
-
-from reactpy.testing import GITHUB_ACTIONS
-
-pytestmark = [pytest.mark.flaky(reruns=10 if GITHUB_ACTIONS else 1)]
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -15,8 +15,6 @@
 )
 from reactpy.testing.display import _playwright_visible
 
-from . import pytestmark  # noqa: F401
-
 REACTPY_ASYNC_RENDERING.set_current(True)
 REACTPY_DEBUG.set_current(True)
 
diff --git a/tests/test_asgi/test_middleware.py b/tests/test_asgi/test_middleware.py
@@ -15,8 +15,6 @@
 from reactpy.executors.asgi.middleware import ReactPyMiddleware
 from reactpy.testing import BackendFixture, DisplayFixture
 
-from .. import pytestmark  # noqa: F401
-
 
 @pytest.fixture(scope="module")
 async def display(browser):
diff --git a/tests/test_asgi/test_pyscript.py b/tests/test_asgi/test_pyscript.py
@@ -12,8 +12,6 @@
 from reactpy.executors.asgi.pyscript import ReactPyCsr
 from reactpy.testing import BackendFixture, DisplayFixture
 
-from .. import pytestmark  # noqa: F401
-
 
 @pytest.fixture(scope="module")
 async def display(browser):
diff --git a/tests/test_asgi/test_standalone.py b/tests/test_asgi/test_standalone.py
@@ -13,8 +13,6 @@
 from reactpy.testing.common import REACTPY_TESTS_DEFAULT_TIMEOUT
 from reactpy.types import Connection, Location
 
-from .. import pytestmark  # noqa: F401
-
 
 async def test_display_simple_hello_world(display: DisplayFixture):
     @reactpy.component
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -6,8 +6,6 @@
 from tests.tooling.common import DEFAULT_TYPE_DELAY
 from tests.tooling.hooks import use_counter
 
-from . import pytestmark  # noqa: F401
-
 JS_DIR = Path(__file__).parent / "js"
 
 
diff --git a/tests/test_core/test_component.py b/tests/test_core/test_component.py
@@ -1,8 +1,6 @@
 import reactpy
 from reactpy.testing import DisplayFixture
 
-from .. import pytestmark  # noqa: F401
-
 
 def test_component_repr():
     @reactpy.component
diff --git a/tests/test_core/test_events.py b/tests/test_core/test_events.py
@@ -16,8 +16,6 @@
 from reactpy.types import Event
 from tests.tooling.common import DEFAULT_TYPE_DELAY
 
-from .. import pytestmark  # noqa: F401
-
 
 def test_event_handler_repr():
     handler = EventHandler(lambda: None)
diff --git a/tests/test_core/test_hooks.py b/tests/test_core/test_hooks.py
@@ -13,8 +13,6 @@
 from reactpy.utils import Ref
 from tests.tooling.common import DEFAULT_TYPE_DELAY, update_message
 
-from .. import pytestmark  # noqa: F401
-
 
 async def test_must_be_rendering_in_layout_to_use_hooks():
     @reactpy.component
diff --git a/tests/test_html.py b/tests/test_html.py
@@ -7,8 +7,6 @@
 from tests.tooling.common import DEFAULT_TYPE_DELAY
 from tests.tooling.hooks import use_counter
 
-from . import pytestmark  # noqa: F401
-
 
 async def test_script_re_run_on_content_change(display: DisplayFixture):
     @component
diff --git a/tests/test_pyscript/test_components.py b/tests/test_pyscript/test_components.py
@@ -8,8 +8,6 @@
 from reactpy.testing import BackendFixture, DisplayFixture
 from reactpy.testing.backend import root_hotswap_component
 
-from .. import pytestmark  # noqa: F401
-
 
 @pytest.fixture(scope="module")
 async def display(browser):
diff --git a/tests/test_reactjs/test_modules.py b/tests/test_reactjs/test_modules.py
@@ -7,8 +7,6 @@
 from reactpy.reactjs import component_from_string, import_reactjs
 from reactpy.testing import BackendFixture, DisplayFixture
 
-from .. import pytestmark  # noqa: F401
-
 JS_FIXTURES_DIR = Path(__file__).parent / "js_fixtures"
 
 
diff --git a/tests/test_reactjs/test_modules_from_npm.py b/tests/test_reactjs/test_modules_from_npm.py
@@ -6,8 +6,6 @@
 from reactpy.reactjs import component_from_npm, import_reactjs
 from reactpy.testing import BackendFixture, DisplayFixture
 
-from .. import pytestmark  # noqa: F401
-
 MISSING_IMPORT_MAP_MSG = "ReactPy did not detect a suitable JavaScript import map"
 
 
diff --git a/tests/test_sample.py b/tests/test_sample.py
@@ -1,8 +1,6 @@
 from reactpy.testing import DisplayFixture
 from tests.sample import SampleApp
 
-from . import pytestmark  # noqa: F401
-
 
 async def test_sample_app(display: DisplayFixture):
     await display.show(SampleApp)
diff --git a/tests/test_testing.py b/tests/test_testing.py
@@ -10,8 +10,6 @@
 from reactpy.testing.display import DisplayFixture
 from tests.sample import SampleApp
 
-from . import pytestmark  # noqa: F401
-
 
 def test_assert_reactpy_logged_does_not_suppress_errors():
     with pytest.raises(RuntimeError, match=r"expected error"):
diff --git a/tests/test_web/test_module.py b/tests/test_web/test_module.py
@@ -21,8 +21,6 @@
 )
 from reactpy.types import InlineJavaScript
 
-from .. import pytestmark  # noqa: F401
-
 JS_FIXTURES_DIR = Path(__file__).parent / "js_fixtures"
 
 
diff --git a/tests/test_widgets.py b/tests/test_widgets.py
@@ -5,8 +5,6 @@
 from reactpy.testing import DisplayFixture, poll
 from tests.tooling.common import DEFAULT_TYPE_DELAY
 
-from . import pytestmark  # noqa: F401
-
 HERE = Path(__file__).parent
 
 

Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,6 @@`
`15`	`15`	`)`
`16`	`16`	`from reactpy.testing.display import _playwright_visible`
`17`	`17`
`18`		`-from . import pytestmark # noqa: F401`
`19`		`-`
`20`	`18`	`REACTPY_ASYNC_RENDERING.set_current(True)`
`21`	`19`	`REACTPY_DEBUG.set_current(True)`
`22`	`20`