allow specifying expected response type #58
Conversation
| BYTES = "bytes" | ||
| NO_CONTENT = "no_content" | ||
|
|
||
| ResponseTypeLiteral = Literal["json", "text", "bytes", "no_content"] No newline at end of file |
There was a problem hiding this comment.
do we really need this literal?
There was a problem hiding this comment.
it's more convenient and faster, we remove one useless import
src/dataclass_rest/rest.py
Outdated
| additional_params: Optional[Dict[str, Any]] = None, | ||
| method_class: Optional[Callable[..., BoundMethod]] = None, | ||
| send_json: bool = True, | ||
| response_type: Optional[ResponseTypeLiteral] = "json", |
There was a problem hiding this comment.
maybe use enum here? anyway I do not see why we should allow None value
response_type: ResponseType = ResponseType.json,There was a problem hiding this comment.
I don't think so, it's more convenient to use a literal. This value is optional and by default it's json
src/dataclass_rest/http/aiohttp.py
Outdated
| case ResponseType.BYTES: | ||
| return await response.read() | ||
| case ResponseType.NO_CONTENT: | ||
| return None |
There was a problem hiding this comment.
should we validate content-length here?
I'd rather have 2 cases here:
- SKIP
- NO_CONTENT
There was a problem hiding this comment.
- content-length I think validation has a place to be, but shouldn't it be at the HTTP level?
(I think we should ask the community) - I think it's unnecessary, maybe it will confuse
src/dataclass_rest/http/aiohttp.py
Outdated
| async def _response_body(self, response: ClientResponse) -> Any: | ||
| try: | ||
| return await response.json() | ||
| match self.response_type: |
There was a problem hiding this comment.
let's avoid match for now, just in case we want to supper older python
|
2 participants
No description provided.