fix

Author: samsonasik

rules/Php82/Rector/Class_/ReadOnlyClassRector.php

@@ -9,7 +9,6 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Property;
 use Rector\Core\NodeAnalyzer\ClassAnalyzer;
-use Rector\Core\NodeAnalyzer\PromotedPropertyParamCleaner;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\ValueObject\MethodName;
 use Rector\Core\ValueObject\PhpVersionFeature;
@@ -35,8 +34,7 @@ final class ReadOnlyClassRector extends AbstractRector implements MinPhpVersionI
     public function __construct(
         private readonly ClassAnalyzer $classAnalyzer,
         private readonly VisibilityManipulator $visibilityManipulator,
-        private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer,
-        private readonly PromotedPropertyParamCleaner $promotedPropertyParamCleaner
+        private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer
     ) {
     }
 
@@ -89,8 +87,9 @@ public function refactor(Node $node): ?Node
 
         $constructClassMethod = $node->getMethod(MethodName::CONSTRUCT);
         if ($constructClassMethod instanceof ClassMethod) {
-            die;
-            $this->promotedPropertyParamCleaner->cleanFromFlags($constructClassMethod->getParams());
+            foreach ($constructClassMethod->getParams() as $param) {
+                $this->visibilityManipulator->removeReadonly($param);
+            }
         }
 
         foreach ($node->getProperties() as $property) {

rules/Privatization/NodeManipulator/VisibilityManipulator.php

@@ -58,17 +58,8 @@ public function makeNonFinal(Class_ | ClassMethod $node): void
     /**
      * This way "abstract", "static", "final" are kept
      */
-    public function removeVisibility(Class_ | ClassMethod | Property | ClassConst $node): void
+    public function removeVisibility(ClassMethod | Property | ClassConst $node): void
     {
-        if ($node instanceof Class_ && $node->flags === 0) {
-            $node->flags -= Class_::MODIFIER_READONLY;
-            return;
-        }
-
-        if ($node instanceof Class_) {
-            return;
-        }
-
         // no modifier
         if ($node->flags === 0) {
             return;
@@ -163,7 +154,7 @@ private function replaceVisibilityFlag(Class_ | ClassMethod | Property | ClassCo
             $this->makeNonStatic($node);
         }
 
-        if ($visibility !== Visibility::STATIC && $visibility !== Visibility::ABSTRACT && $visibility !== Visibility::FINAL) {
+        if ($visibility !== Visibility::STATIC && $visibility !== Visibility::ABSTRACT && $visibility !== Visibility::FINAL && $visibility !== Visibility::READONLY) {
             $this->removeVisibility($node);
         }