Skip to content

Commit a91ac10

Browse files
committed
fix
1 parent 62626ce commit a91ac10

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

rules/Php82/Rector/Class_/ReadOnlyClassRector.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public function refactor(Node $node): ?Node
8383
return null;
8484
}
8585

86-
$this->visibilityManipulator->changeNodeVisibility($node, Visibility::READONLY);
86+
$this->visibilityManipulator->makeReadonly($node);
8787

8888
$constructClassMethod = $node->getMethod(MethodName::CONSTRUCT);
8989
if ($constructClassMethod instanceof ClassMethod) {

rules/Privatization/NodeManipulator/VisibilityManipulator.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,15 @@ public function removeVisibility(ClassMethod | Property | ClassConst $node): voi
7878
}
7979
}
8080

81-
public function changeNodeVisibility(Class_ | ClassMethod | Property | ClassConst $node, int $visibility): void
81+
public function changeNodeVisibility(ClassMethod | Property | ClassConst $node, int $visibility): void
8282
{
8383
Assert::oneOf($visibility, [
8484
Visibility::PUBLIC,
8585
Visibility::PROTECTED,
8686
Visibility::PRIVATE,
8787
Visibility::STATIC,
8888
Visibility::ABSTRACT,
89-
Visibility::FINAL,
90-
Visibility::READONLY,
89+
Visibility::FINAL
9190
]);
9291

9392
$this->replaceVisibilityFlag($node, $visibility);
@@ -118,7 +117,7 @@ public function removeAbstract(ClassMethod $classMethod): void
118117
$classMethod->flags -= Class_::MODIFIER_ABSTRACT;
119118
}
120119

121-
public function makeReadonly(Property | Param $node): void
120+
public function makeReadonly(Class_ | Property | Param $node): void
122121
{
123122
$this->addVisibilityFlag($node, Visibility::READONLY);
124123
}
@@ -147,14 +146,14 @@ private function removeVisibilityFlag(
147146
$node->flags &= ~$visibility;
148147
}
149148

150-
private function replaceVisibilityFlag(Class_ | ClassMethod | Property | ClassConst $node, int $visibility): void
149+
private function replaceVisibilityFlag(ClassMethod | Property | ClassConst $node, int $visibility): void
151150
{
152151
$isStatic = $node instanceof ClassMethod && $node->isStatic();
153152
if ($isStatic) {
154153
$this->makeNonStatic($node);
155154
}
156155

157-
if ($visibility !== Visibility::STATIC && $visibility !== Visibility::ABSTRACT && $visibility !== Visibility::FINAL && $visibility !== Visibility::READONLY) {
156+
if ($visibility !== Visibility::STATIC && $visibility !== Visibility::ABSTRACT && $visibility !== Visibility::FINAL) {
158157
$this->removeVisibility($node);
159158
}
160159

0 commit comments

Comments
 (0)