Skip to content

Commit 2f2a970

Browse files
committed
use editorconfig to enforce code rules
1 parent ed92c34 commit 2f2a970

21 files changed

+83
-31
lines changed

.editorconfig

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
root = true
2+
3+
[*.cs]
4+
indent_size = 4
5+
indent_style = space
6+
trim_trailing_whitespace = true
7+
8+
# Avoid "this." and "Me." if not necessary
9+
dotnet_style_qualification_for_field = false:suggestion
10+
dotnet_style_qualification_for_property = false:suggestion
11+
dotnet_style_qualification_for_method = false:suggestion
12+
dotnet_style_qualification_for_event = false:suggestion
13+
14+
# Suggest more modern language features when available
15+
csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
16+
csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
17+
csharp_style_inlined_variable_declaration = true:suggestion
18+
csharp_style_throw_expression = true:suggestion
19+
csharp_style_conditional_delegate_call = true:suggestion
20+
21+
# Newline settings
22+
csharp_new_line_before_open_brace = all
23+
csharp_new_line_before_else = true
24+
csharp_new_line_before_catch = true
25+
csharp_new_line_before_finally = true
26+
csharp_new_line_before_members_in_object_initializers = true
27+
csharp_new_line_before_members_in_anonymous_types = true
28+
29+
# Xml project files
30+
[*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,projitems,shproj}]
31+
indent_size = 2
32+
indent_style = space
33+
34+
# Xml config files
35+
[*.{props,targets,ruleset,config,nuspec,resx,vsixmanifest,vsct}]
36+
indent_size = 2
37+
indent_style = space

NRedisStack.sln

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Build", "Build", "{84D6210F
1515
Directory.Packages.props = Directory.Packages.props
1616
global.json = global.json
1717
version.json = version.json
18+
.editorconfig = .editorconfig
19+
EndProjectSection
20+
EndProject
21+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{CBEB7980-923E-49D1-B8D5-561E313AF525}"
22+
ProjectSection(SolutionItems) = preProject
23+
src\.editorconfig = src\.editorconfig
1824
EndProjectSection
1925
EndProject
2026
Global
@@ -39,4 +45,7 @@ Global
3945
{F14F6342-14A0-4DDD-AB05-C425B1AD8001}.Release|Any CPU.ActiveCfg = Release|Any CPU
4046
{F14F6342-14A0-4DDD-AB05-C425B1AD8001}.Release|Any CPU.Build.0 = Release|Any CPU
4147
EndGlobalSection
48+
GlobalSection(NestedProjects) = preSolution
49+
{CBEB7980-923E-49D1-B8D5-561E313AF525} = {84D6210F-9A65-427A-965F-57E7B76424AB}
50+
EndGlobalSection
4251
EndGlobal

src/.editorconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[*.cs]
2+
dotnet_sort_system_directives_first = false # we don't want this in docs, because of hidden sections

src/NRedisStack/Bloom/BloomCommandBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1+
using NRedisStack.Bloom.Literals;
12
using NRedisStack.RedisStackCommands;
23
using StackExchange.Redis;
3-
using NRedisStack.Bloom.Literals;
44
namespace NRedisStack;
55

66
public static class BloomCommandBuilder

src/NRedisStack/CoreCommands/CoreCommandBuilder.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
using NRedisStack.RedisStackCommands;
2-
using NRedisStack.Core.Literals;
31
using NRedisStack.Core;
42
using NRedisStack.Core.DataTypes;
3+
using NRedisStack.Core.Literals;
4+
using NRedisStack.RedisStackCommands;
55
using StackExchange.Redis;
66

77
namespace NRedisStack;

src/NRedisStack/ResponseParser.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
using NRedisStack.Literals.Enums;
2-
using NRedisStack.DataTypes;
3-
using NRedisStack.Extensions;
4-
using StackExchange.Redis;
51
using NRedisStack.Bloom.DataTypes;
62
using NRedisStack.Core.DataTypes;
7-
using NRedisStack.CuckooFilter.DataTypes;
83
using NRedisStack.CountMinSketch.DataTypes;
9-
using NRedisStack.TopK.DataTypes;
10-
using NRedisStack.Tdigest.DataTypes;
4+
using NRedisStack.CuckooFilter.DataTypes;
5+
using NRedisStack.DataTypes;
6+
using NRedisStack.Extensions;
7+
using NRedisStack.Literals.Enums;
118
using NRedisStack.Search;
9+
using NRedisStack.Tdigest.DataTypes;
10+
using NRedisStack.TopK.DataTypes;
11+
using StackExchange.Redis;
1212

1313
namespace NRedisStack;
1414

src/NRedisStack/Search/Query.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
using System.Globalization;
2-
using NRedisStack.Search.Literals;
1+
using NRedisStack.Search.Literals;
32
using StackExchange.Redis;
3+
using System.Globalization;
44

55
namespace NRedisStack.Search;
66

src/NRedisStack/Search/Schema.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
using System.Diagnostics;
2-
using NRedisStack.Search.Literals;
1+
using NRedisStack.Search.Literals;
2+
using System.Diagnostics;
33
using static NRedisStack.Search.Schema.GeoShapeField;
44
using static NRedisStack.Search.Schema.VectorField;
55

src/NRedisStack/Search/SearchCommandBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
using NRedisStack.Search.Literals;
21
using NRedisStack.RedisStackCommands;
32
using NRedisStack.Search;
3+
using NRedisStack.Search.Literals;
44
using StackExchange.Redis;
55
namespace NRedisStack;
66

src/NRedisStack/Tdigest/TdigestCommandBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
using NRedisStack.Literals;
2-
using StackExchange.Redis;
32
using NRedisStack.RedisStackCommands;
3+
using StackExchange.Redis;
44

55
namespace NRedisStack;
66

0 commit comments

Comments
 (0)