naming is hard

Author: mgravell

src/NRedisStack/PublicAPI/PublicAPI.Unshipped.txt

@@ -67,6 +67,7 @@
 [NRS001]override NRedisStack.Search.ApplyExpression.ToString() -> string!
 [NRS001]override NRedisStack.Search.HybridSearchQuery.Combiner.ToString() -> string!
 [NRS001]override NRedisStack.Search.Scorer.ToString() -> string!
+[NRS001]override NRedisStack.Search.VectorData.ToString() -> string!
 [NRS001]override NRedisStack.Search.VectorSearchMethod.ToString() -> string!
 [NRS001]static NRedisStack.Search.ApplyExpression.implicit operator NRedisStack.Search.ApplyExpression(string! expression) -> NRedisStack.Search.ApplyExpression
 [NRS001]static NRedisStack.Search.HybridSearchQuery.Combiner.Linear(double alpha = 0.3, double beta = 0.7) -> NRedisStack.Search.HybridSearchQuery.Combiner!

src/NRedisStack/Search/HybridSearchQuery.VectorSearchConfig.cs

@@ -97,7 +97,7 @@ internal int GetOwnArgsCount()
             int count = 0;
             if (HasValue)
             {
-                count += 2 + _vectorData.ArgsCount();
+                count += 2 + _vectorData.Base64ArgsCount();
                 if (_method != null) count += _method.GetOwnArgsCount();
                 if (_filter != null) count += 2;
 
@@ -112,7 +112,7 @@ internal void AddOwnArgs(List<object> args)
             {
                 args.Add("VSIM");
                 args.Add(_fieldName);
-                _vectorData.AddArgs(args);
+                _vectorData.AddBase64Args(args);
 
                 _method?.AddOwnArgs(args);
                 if (_filter != null)

src/NRedisStack/Search/VectorData.cs

@@ -31,12 +31,16 @@ private protected VectorData()
     /// </summary>
     public static implicit operator VectorData(ReadOnlyMemory<float> vector) => new VectorDataSingle(vector);
 
-    internal virtual void AddArgs(List<object> args) => args.Add(ToString() ?? "");
-    internal virtual int ArgsCount() => 1;
+    internal void AddBase64Args(List<object> args) => args.Add(ToBase64());
+    internal int Base64ArgsCount() => 1;
+    private protected abstract string ToBase64();
+
+    /// <inheritdoc/>
+    public override string ToString() => ToBase64();
 
     private sealed class VectorDataSingle(ReadOnlyMemory<float> vector) : VectorData
     {
-        public override string ToString()
+        private protected override string ToBase64()
         {
             if (!BitConverter.IsLittleEndian) ThrowBigEndian(); // we could loop and reverse each, but...how to test?
             var bytes = MemoryMarshal.AsBytes(vector.Span);
@@ -54,7 +58,7 @@ public override string ToString()
 
     private sealed class VectorDataBase64(string vector) : VectorData
     {
-        public override string ToString() => vector;
+        private protected override string ToBase64() => vector;
     }
 
     private protected static void ThrowBigEndian() =>