Skip to content

Commit 8af9878

Browse files
RI-000: keep manual trigger only for e2e (#4995)
1 parent 2f73282 commit 8af9878

File tree

1 file changed

+4
-34
lines changed

1 file changed

+4
-34
lines changed

.github/workflows/tests-e2e.yml

Lines changed: 4 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,6 @@
11
name: ✅ E2E Tests
2-
run-name: >
3-
E2E • ${{ github.event_name == 'pull_request_review'
4-
&& format('PR #{0} {1}', github.event.pull_request.number, github.event.pull_request.title)
5-
|| github.ref_name }} • by ${{ github.actor }}
62

73
on:
8-
pull_request_review:
9-
types: [submitted]
10-
114
workflow_dispatch:
125
inputs:
136
debug:
@@ -21,43 +14,24 @@ permissions:
2114

2215
# Cancel a previous run workflow
2316
concurrency:
24-
group: ${{ github.workflow }}-${{ github.event.pull_request.head.sha || github.ref }}-e2e
25-
cancel-in-progress: false
17+
group: ${{ github.workflow }}-${{ github.ref }}-e2e
18+
cancel-in-progress: true
2619

2720
jobs:
28-
approval-dedupe:
29-
uses: ./.github/workflows/approval-dedupe.yml
30-
secrets: inherit
31-
with:
32-
workflow_filename: tests-e2e.yml
33-
require_approval: true
34-
allow_workflow_dispatch: true
35-
3621
build-docker:
37-
needs: approval-dedupe
38-
if: needs.approval-dedupe.outputs.mode == 'run'
3922
uses: ./.github/workflows/pipeline-build-docker.yml
4023
secrets: inherit
4124
with:
4225
debug: ${{ inputs.debug || false }}
4326
for_e2e_tests: true
4427

4528
build-appimage:
46-
needs: approval-dedupe
47-
if: needs.approval-dedupe.outputs.mode == 'run'
4829
uses: ./.github/workflows/pipeline-build-linux.yml
4930
secrets: inherit
5031
with:
5132
target: build_linux_appimage_x64
5233
debug: ${{ inputs.debug || false }}
5334

54-
builds-complete:
55-
needs: [build-docker, build-appimage]
56-
runs-on: ubuntu-latest
57-
steps:
58-
- name: Both builds finished
59-
run: echo "Docker and AppImage builds completed"
60-
6135
e2e-docker-tests-smoke:
6236
name: "E2E: Smoke (Docker)"
6337
needs: build-docker
@@ -83,25 +57,23 @@ jobs:
8357
debug: ${{ inputs.debug || false }}
8458

8559
tests-e2e-playwright:
86-
needs: builds-complete
60+
needs: build-docker
8761
uses: ./.github/workflows/tests-e2e-playwright.yml
8862
secrets: inherit
8963
with:
9064
debug: ${{ inputs.debug || false }}
9165

9266
e2e-appimage-tests:
93-
needs: builds-complete
67+
needs: build-appimage
9468
uses: ./.github/workflows/tests-e2e-appimage.yml
9569
secrets: inherit
9670
with:
9771
debug: ${{ inputs.debug || false }}
9872

9973
clean:
10074
uses: ./.github/workflows/clean-deployments.yml
101-
if: always() && needs.approval-dedupe.outputs.mode == 'run'
10275
needs:
10376
[
104-
approval-dedupe,
10577
e2e-docker-tests-smoke,
10678
e2e-docker-tests-critical-path,
10779
e2e-docker-tests-regression,
@@ -112,10 +84,8 @@ jobs:
11284
# Remove artifacts from github actions
11385
remove-artifacts:
11486
name: Remove artifacts
115-
if: needs.approval-dedupe.outputs.mode == 'run'
11687
needs:
11788
[
118-
approval-dedupe,
11989
e2e-docker-tests-smoke,
12090
e2e-docker-tests-critical-path,
12191
e2e-docker-tests-regression,

0 commit comments

Comments
 (0)