Skip to content

Conversation

@adobrzhansky
Copy link
Collaborator

No description provided.

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 2 important findings in this PR that you should review.


Jit encountered an internal error and cannot comment on each finding.

You can ask a Jit admin to comment #jit_ignore_all on this PR to ignore the findings.

Here are the findings in this PR:

  • Security Control: Static Code Analysis Semgrep Pro
    • Type: Yaml.Github-Actions.Security.Run-Shell-Injection.Run-Shell-Injection
    • Description: Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".
    • Severity: HIGH
    • Learn More: Link
    • Filename: .github/actions/build-and-tag-locally/action.yml
    • Lines: 40-78
  • Security Control: Docker Scan
    • Type: Image User Should Not Be 'Root'
    • Description: Running containers with 'root' user can lead to a container escape situation. It is a best practice to run containers as non-root users, which can be done by adding a 'USER' statement to the Dockerfile.
    • Severity: HIGH
    • Learn More: Link
    • Filename: debian/Dockerfile
    • Lines: 1-1

@adobrzhansky adobrzhansky force-pushed the update-debian-base-image branch from 6c38b46 to a60ee4f Compare December 8, 2025 17:32
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed as a comment.
It’s highly recommended that you fix this security issue before merge.

Until now, you ignored/fixed 2 findings.

@adobrzhansky adobrzhansky force-pushed the update-debian-base-image branch from a60ee4f to 8743428 Compare December 8, 2025 17:57
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed as a comment.
It’s highly recommended that you fix this security issue before merge.

Until now, you ignored/fixed 3 findings.

@adobrzhansky adobrzhansky merged commit ec9d20f into release/8.4 Dec 9, 2025
21 of 23 checks passed
@adobrzhansky adobrzhansky deleted the update-debian-base-image branch December 9, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants