Added warning logs for triaging issues of default local redis instance being used although remote async redis instance is provided #369
+28
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is happening?
When below conditions are met -
EmbeddingCache
withasync_redis_client
only.get
method ofEmbeddingCache
-cache.get(text=text, model_name=model_name)
It defaults to using local redis client instead of the supplied
async_redis_client
without any warnings. Which in turn results to empty cache always.It gets worse when we use
SemanticCache
and useEmbeddingCache
withasync_redis_client
in itsvectorizer
Since
SemanticCache
only accepts synchronousredis_client
we may tend to usecheck
method orstore
method instead ofastore
oracheck
method, which in turn again callscache.get(text=text, model_name=model_name)
and it return EMPTY CACHEHence warning logs become neccessary.
What is done?
I have added some warning logs in case if developer supplies
async_redis_client
but usesget
/mget
/set
/mset
methods.