-
-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
👍 phase/yesPost is accepted and can be worked onPost is accepted and can be worked on🙆 yes/confirmedThis is confirmed and ready to be worked onThis is confirmed and ready to be worked on
Description
Initial checklist
- I read the support docs
- I read the contributing guide
- I agree to follow the code of conduct
- I searched issues and discussions and couldn’t find anything (or linked relevant results below)
Problem
When developing remark plugins, I make the language server crash from time-to-time.
Also, it doesn't always seem to reload my config when I want.
I'd like to have a vscode command, similar to the typescript language server, where I can forcefully reload the remark plugin without having to reload vscode or the plugin.
Current solutions
ctrl+shift+p> Developer: Reload window
However, this destroys any open terminals or debugging windows.
Proposed solutions
Have a similar command to the typescript language server, that reloads the language server.
- https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/src/commands/restartTsServer.ts
- https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/src/typescriptServiceClient.ts#L319
- https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/package.json#L1570
- https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/package.nls.json#L61
- They have this whole command manager
https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/src/commands/index.ts#L22
I think just using thevscode.commands.registerCommandapproach is good enough.
Metadata
Metadata
Assignees
Labels
👍 phase/yesPost is accepted and can be worked onPost is accepted and can be worked on🙆 yes/confirmedThis is confirmed and ready to be worked onThis is confirmed and ready to be worked on