Skip to content

Conversation

@mjackson
Copy link
Member

@mjackson mjackson commented May 2, 2025

Fixes #11940

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: 50aedcc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 50b96f9 into dev Aug 19, 2025
5 checks passed
@brophdawg11 brophdawg11 deleted the gh-11940-2 branch August 19, 2025 18:43
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.8.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey changed the title Properly escape :param values in generatePath() fix(react-router/router): properly escape :param values in generatePath() Aug 21, 2025
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.8.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

dgdavid added a commit to agama-project/agama that referenced this pull request Nov 10, 2025
It was introduced to work around React Router v6's issue of not encoding
parameters in the generatePath function. However, after migrating to v7,
tests began failing due to double encoding. This revealed that React
Router v7 already handles encoding parameters in generatePath. See
remix-run/react-router#13530

Thus, this commit reverts the changes made in
#2576
dgdavid added a commit to agama-project/agama that referenced this pull request Nov 10, 2025
## Problem

React Router v7 was released almost a year now (see
https://reactrouter.com/changelog#v700), but it has not been updated in
Agama yet. In addition to the obvious benefit of keeping dependencies
up-to-date, updating it might help to address some limitations we have
found with the v6 version, like
06d858c

## Solution

Migrate React Router dependency to its latest version.

## Testing

- Adapted existing tests.

## Notes

This migration has been straightforward, and as of now, Agama is using
Data Mode (see https://reactrouter.com/start/modes). However, this could
change in the future if we find advantages in switching to Declarative
or Framework Mode. Before making any decisions, we’ll need to work on
`src/App.tsx` along with the changes planned for the api-v2 branch that
this PR is based on.

## Documentation


 * https://reactrouter.com/upgrading/v6
*
remix-run/react-router#12363 (comment)
* remix-run/react-router#13530 (`generatePath`
now encodes URL params by default, related to
#2576)
 * https://www.typescriptlang.org/tsconfig/#moduleResolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: generatePath/matchPath don't handle encoding/decoding / the same

4 participants