clippy 1.91

Author: rene-d

src/year2015/day9/day9.rs

@@ -43,7 +43,7 @@ pub fn solve(data: &str) -> (u32, u32) {
             let from = permutated[i];
             let to = permutated[i + 1];
 
-            distance += distances.get(&(from.to_string(), to.to_string())).unwrap();
+            distance += distances.get(&(from.clone(), to.clone())).unwrap();
         }
 
         if distance < min_distance {

src/year2020/day8/day8.rs

@@ -48,7 +48,7 @@ impl Puzzle {
     fn part2(&self) -> i32 {
         let mut boot_code = self.boot_code.clone();
         for ip in 0..boot_code.len() {
-            let instr = &boot_code[ip].to_string();
+            let instr = &boot_code[ip].clone();
 
             let (op, imm) = instr.split_once(' ').unwrap();
 
@@ -67,7 +67,7 @@ impl Puzzle {
                 return acc;
             }
 
-            boot_code[ip] = instr.to_string();
+            boot_code[ip].clone_from(instr);
         }
         0
     }

src/year2021/day19/day19.rs

@@ -80,8 +80,7 @@ pub fn solve(data: &str) -> (usize, i32) {
                 g_scan.push(point);
             }
 
-            for rotation in 0..24 {
-                let b_scan = scanner_rotated_list[*scanner_id][rotation].clone();
+            for b_scan in scanner_rotated_list[*scanner_id].iter().take(24) {
 
                 let mut match_points: FxHashMap<Point, i32> = FxHashMap::default();
 
@@ -106,7 +105,7 @@ pub fn solve(data: &str) -> (usize, i32) {
                     if count >= 12 {
                         scanner_coords[*scanner_id] = point.clone();
 
-                        for p in &b_scan {
+                        for p in b_scan {
                             let q = Point {
                                 x: point.x + p.x,
                                 y: point.y + p.y,

src/year2021/day25/day25.rs

@@ -60,6 +60,7 @@ fn do_move(grid: &mut [Vec<u8>]) -> bool {
     }
 
     // then the south-facing herd moves.
+    #[allow(clippy::needless_range_loop)]
     for y in 0..ny {
         for x in 0..nx {
             let c = grid[y][x];

src/year2021/day4/day4.rs

@@ -84,6 +84,8 @@ fn sum(grid: &[[i32; 5]; 5]) -> i32 {
 
 /// `has_win` returns true if the grid has an cleared row or column
 fn win(grid: &[[i32; 5]; 5]) -> bool {
+
+    #[allow(clippy::needless_range_loop)]
     for i in 0..5 {
         if grid[i][0] == -1
             && grid[i][1] == -1

src/year2021/day5/day5.rs

@@ -27,6 +27,8 @@ pub fn solve(data: &str) -> (i32, i32) {
             if y1 > y2 {
                 std::mem::swap(&mut y1, &mut y2);
             }
+
+            #[allow(clippy::needless_range_loop)]
             for y in y1..=y2 {
                 grid[x1][y] += 1;
             }

src/year2021/day8/day8.rs

@@ -87,14 +87,14 @@ fn part2(data: &str) -> u32 {
         }
 
         map.insert(zero.to_string(), 0);
-        map.insert(one.to_string(), 1);
+        map.insert(one.clone(), 1);
         map.insert(two.to_string(), 2);
         map.insert(three.to_string(), 3);
-        map.insert(four.to_string(), 4);
+        map.insert(four.clone(), 4);
         map.insert(five.to_string(), 5);
         map.insert(six.to_string(), 6);
-        map.insert(seven.to_string(), 7);
-        map.insert(eight.to_string(), 8);
+        map.insert(seven.clone(), 7);
+        map.insert(eight.clone(), 8);
         map.insert(nine.to_string(), 9);
 
         let mut r = 0;

src/year2024/day23/day23.rs

@@ -54,14 +54,14 @@ impl Puzzle {
 
         for (n1, n2) in &self.connections {
             graph
-                .entry(n1.to_string())
+                .entry(n1.clone())
                 .or_default()
-                .insert(n2.to_string());
+                .insert(n2.clone());
 
             graph
-                .entry(n2.to_string())
+                .entry(n2.clone())
                 .or_default()
-                .insert(n1.to_string());
+                .insert(n1.clone());
         }
 
         for (node, neighbors) in &graph {

src/year2024/day24/day24.rs

@@ -116,7 +116,7 @@ impl Puzzle {
                 if let Some(&a) = wires.get(&gate.a) {
                     if let Some(&b) = wires.get(&gate.b) {
                         let r = gate.op.eval(a, b);
-                        *wires.entry(gate.r.to_string()).or_default() = r;
+                        *wires.entry(gate.r.clone()).or_default() = r;
                         continue;
                     }
                 }