Merge pull request #183 from hazendaz/main

hazendaz · web-flow · commit f00445d84ded · 2024-04-05T21:43:40.000-04:00
[cleanup] Use try with resources to ensure reader is closed
diff --git a/src/main/java/net/revelc/code/formatter/xml/lib/XmlDocumentFormatter.java b/src/main/java/net/revelc/code/formatter/xml/lib/XmlDocumentFormatter.java
@@ -97,10 +97,9 @@ public String format(String documentText) {
             validateWellFormedness(documentText);
         }
 
-        Reader reader = new StringReader(documentText);
         FormatState state = new FormatState();
 
-        try {
+        try (Reader reader = new StringReader(documentText)) {
             while (true) {
                 reader.mark(1);
                 int intChar = reader.read();
@@ -111,7 +110,6 @@ public String format(String documentText) {
                 }
                 copyNode(reader, state);
             }
-            reader.close();
         } catch (IOException e) {
             logger.error("{}", e.getMessage());
             logger.debug("", e);

Original file line number	Diff line number	Diff line change
`@@ -97,10 +97,9 @@ public String format(String documentText) {`
`97`	`97`	`validateWellFormedness(documentText);`
`98`	`98`	`}`
`99`	`99`
`100`		`- Reader reader = new StringReader(documentText);`
`101`	`100`	`FormatState state = new FormatState();`
`102`	`101`
`103`		`- try {`
	`102`	`+ try (Reader reader = new StringReader(documentText)) {`
`104`	`103`	`while (true) {`
`105`	`104`	`reader.mark(1);`
`106`	`105`	`int intChar = reader.read();`
`@@ -111,7 +110,6 @@ public String format(String documentText) {`
`111`	`110`	`}`
`112`	`111`	`copyNode(reader, state);`
`113`	`112`	`}`
`114`		`- reader.close();`
`115`	`113`	`} catch (IOException e) {`
`116`	`114`	`logger.error("{}", e.getMessage());`
`117`	`115`	`logger.debug("", e);`