Skip to content

Commit ad57fa1

Browse files
committed
lib: Don't set the response status code in system reset handler
SYSRST_RESET service is a posted request and does not return a response. Though the implementation does not return the acknowledgement message for this service hence, remove the redundant setting of response status code from the system reset handler Signed-off-by: Rahul Pathak <[email protected]>
1 parent 0f3f3c3 commit ad57fa1

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

include/librpmi.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -736,10 +736,10 @@ struct rpmi_service_group {
736736
rpmi_uint32_t servicegroup_version;
737737

738738
/**
739-
* RISC-V privilagel level bitmap where this group
739+
* RISC-V privilege level bitmap where this group
740740
* is allowed to be accessible. enum rpmi_privilege_level
741741
* values represents the bit positions which if are
742-
* set, the access to that privilegel level is enabled
742+
* set, the access to that privilege level is enabled
743743
*/
744744
rpmi_uint32_t privilege_level_bitmap;
745745

@@ -1343,11 +1343,11 @@ struct rpmi_cppc_regs {
13431343
rpmi_uint32_t lowest_perf;
13441344
/* guaranteed performance register (r) */
13451345
rpmi_uint32_t guaranteed_perf;
1346-
/* desired performance regiser (rw) */
1346+
/* desired performance register (rw) */
13471347
rpmi_uint32_t desired_perf;
1348-
/* minimum performance regiser (rw) */
1348+
/* minimum performance register (rw) */
13491349
rpmi_uint32_t min_perf;
1350-
/* maximun performance regiser (rw) */
1350+
/* maximum performance register (rw) */
13511351
rpmi_uint32_t max_perf;
13521352
/* performance reduction tolerance register (rw) */
13531353
rpmi_uint32_t perf_reduction_tolerence;

lib/rpmi_service_group_sysreset.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ static enum rpmi_error rpmi_sysreset_do_reset(struct rpmi_service_group *group,
6969
rpmi_uint8_t *response_data)
7070
{
7171
struct rpmi_sysreset_group *sgrst = group->priv;
72-
rpmi_uint32_t *resp = (void *)response_data;
7372
const rpmi_uint32_t *sysreset_type;
7473
rpmi_uint32_t reset_type;
7574

@@ -82,10 +81,6 @@ static enum rpmi_error rpmi_sysreset_do_reset(struct rpmi_service_group *group,
8281
sgrst->ops->do_system_reset(sgrst->ops_priv, reset_type);
8382
}
8483

85-
/* reset_type is invalid at this point */
86-
*response_datalen = sizeof(*resp);
87-
resp[0] = rpmi_to_xe32(trans->is_be, (rpmi_uint32_t)RPMI_ERR_INVALID_PARAM);
88-
8984
return RPMI_SUCCESS;
9085
}
9186

0 commit comments

Comments
 (0)