Skip to content

Commit 4b9ab15

Browse files
authored
fix: react-native 0.77 compilation for android old-arch (#3930)
* fix: react-native 0.77 compilation for android old-arch * fix example * code review * fix generate
1 parent d3c987f commit 4b9ab15

39 files changed

+1616
-2288
lines changed

android/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ android {
157157
// Add lifecycle compatibility source sets
158158
// Priority order:
159159
// 1. User-defined override (RNMapboxMapsLifecycleCompat)
160-
// 2. React Native version detection (0.78+ uses new API)
160+
// 2. React Native version detection (0.77+ uses new API)
161161
// 3. Conservative default (v25 for better compatibility)
162162

163163
def lifecycleCompat = safeExtGet("RNMapboxMapsLifecycleCompat", null)
@@ -183,8 +183,8 @@ android {
183183
def majorVersion = versionParts[0].toInteger()
184184
def minorVersion = versionParts[1].toInteger()
185185

186-
// React Native < 0.78 needs the old lifecycle API
187-
if (majorVersion == 0 && minorVersion < 78) {
186+
// React Native < 0.77 needs the old lifecycle API
187+
if (majorVersion == 0 && minorVersion < 77) {
188188
logger.info("@rnmapbox/maps: Detected React Native ${rnVersion} - using v25 lifecycle compatibility (old API)")
189189
java.srcDirs += 'src/main/lifecycle-compat/v25'
190190
} else {

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXAtmosphereManagerInterface.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111

1212
import android.view.View;
1313
import com.facebook.react.bridge.Dynamic;
14-
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
15-
16-
public interface RNMBXAtmosphereManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
14+
public interface RNMBXAtmosphereManagerInterface<T extends View> {
1715
void setReactStyle(T view, Dynamic value);
1816
}

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXBackgroundLayerManagerInterface.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111

1212
import android.view.View;
1313
import com.facebook.react.bridge.Dynamic;
14-
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
15-
16-
public interface RNMBXBackgroundLayerManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
14+
public interface RNMBXBackgroundLayerManagerInterface<T extends View> {
1715
void setId(T view, Dynamic value);
1816
void setSourceID(T view, Dynamic value);
1917
void setExisting(T view, Dynamic value);

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXCalloutManagerInterface.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
package com.facebook.react.viewmanagers;
1111

1212
import android.view.View;
13-
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
14-
15-
public interface RNMBXCalloutManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
13+
public interface RNMBXCalloutManagerInterface<T extends View> {
1614
// No props
1715
}

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXCameraManagerInterface.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111

1212
import android.view.View;
1313
import com.facebook.react.bridge.Dynamic;
14-
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
15-
16-
public interface RNMBXCameraManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
14+
public interface RNMBXCameraManagerInterface<T extends View> {
1715
void setMaxBounds(T view, Dynamic value);
1816
void setAnimationDuration(T view, Dynamic value);
1917
void setAnimationMode(T view, Dynamic value);

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXCircleLayerManagerInterface.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111

1212
import android.view.View;
1313
import com.facebook.react.bridge.Dynamic;
14-
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
15-
16-
public interface RNMBXCircleLayerManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
14+
public interface RNMBXCircleLayerManagerInterface<T extends View> {
1715
void setSourceID(T view, Dynamic value);
1816
void setExisting(T view, Dynamic value);
1917
void setFilter(T view, Dynamic value);

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXCustomLocationProviderManagerInterface.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111

1212
import android.view.View;
1313
import com.facebook.react.bridge.Dynamic;
14-
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
15-
16-
public interface RNMBXCustomLocationProviderManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
14+
public interface RNMBXCustomLocationProviderManagerInterface<T extends View> {
1715
void setCoordinate(T view, Dynamic value);
1816
void setHeading(T view, Dynamic value);
1917
}

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXFillExtrusionLayerManagerInterface.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111

1212
import android.view.View;
1313
import com.facebook.react.bridge.Dynamic;
14-
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
15-
16-
public interface RNMBXFillExtrusionLayerManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
14+
public interface RNMBXFillExtrusionLayerManagerInterface<T extends View> {
1715
void setId(T view, Dynamic value);
1816
void setSourceID(T view, Dynamic value);
1917
void setExisting(T view, Dynamic value);

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXFillLayerManagerInterface.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111

1212
import android.view.View;
1313
import com.facebook.react.bridge.Dynamic;
14-
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
15-
16-
public interface RNMBXFillLayerManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
14+
public interface RNMBXFillLayerManagerInterface<T extends View> {
1715
void setSourceID(T view, Dynamic value);
1816
void setExisting(T view, Dynamic value);
1917
void setFilter(T view, Dynamic value);

android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXHeatmapLayerManagerInterface.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111

1212
import android.view.View;
1313
import com.facebook.react.bridge.Dynamic;
14-
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
15-
16-
public interface RNMBXHeatmapLayerManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
14+
public interface RNMBXHeatmapLayerManagerInterface<T extends View> {
1715
void setSourceID(T view, Dynamic value);
1816
void setExisting(T view, Dynamic value);
1917
void setFilter(T view, Dynamic value);

0 commit comments

Comments
 (0)