perf(analyze): optimize find unused refences (1.5x-2x faster)

Author: d-biehl

packages/language_server/src/robotcode/language_server/robotframework/parts/references.py

@@ -1,6 +1,6 @@
 import ast
 from concurrent.futures import CancelledError
-from typing import TYPE_CHECKING, Any, Callable, List, Optional, Type, cast
+from typing import TYPE_CHECKING, Any, Callable, Iterable, List, Optional, Type, cast
 
 from robot.parsing.lexer.tokens import Token as RobotToken
 from robot.parsing.model import statements
@@ -150,7 +150,7 @@ def _find_references_in_workspace(
         self,
         document: TextDocument,
         stop_at_first: bool,
-        func: Callable[..., List[Location]],
+        func: Callable[..., Iterable[Location]],
         *args: Any,
         **kwargs: Any,
     ) -> List[Location]:
@@ -249,73 +249,44 @@ def find_variable_references_in_file(
         doc: TextDocument,
         variable: VariableDefinition,
         include_declaration: bool = True,
-    ) -> List[Location]:
+    ) -> Iterable[Location]:
         try:
             namespace = self.parent.documents_cache.get_namespace(doc)
 
-            if (
-                variable.source
-                and variable.source != str(doc.uri.to_path())
-                and not any(e for e in (namespace.get_resources()).values() if e.library_doc.source == variable.source)
-                and not any(
-                    e for e in namespace.get_variables_imports().values() if e.library_doc.source == variable.source
-                )
-                and not any(e for e in namespace.get_command_line_variables() if e.source == variable.source)
-            ):
-                return []
-
-            result = set()
-            if include_declaration and variable.source:
-                result.add(Location(str(Uri.from_path(variable.source)), variable.name_range))
-
             refs = namespace.get_variable_references()
             if variable in refs:
-                result |= refs[variable]
+                if include_declaration and variable.source == namespace.source:
+                    yield Location(str(Uri.from_path(variable.source)), variable.name_range)
+
+                yield from refs[variable]
 
-            return list(result)
         except (SystemExit, KeyboardInterrupt, CancelledError):
             raise
         except BaseException as e:
             self._logger.exception(e)
 
-        return []
-
     @_logger.call
     def find_keyword_references_in_file(
         self,
         doc: TextDocument,
         kw_doc: KeywordDoc,
-        lib_doc: Optional[LibraryDoc] = None,
         include_declaration: bool = True,
-    ) -> List[Location]:
+    ) -> Iterable[Location]:
         try:
             namespace = self.parent.documents_cache.get_namespace(doc)
 
-            if (
-                lib_doc is not None
-                and lib_doc.source is not None
-                and lib_doc.source != str(doc.uri.to_path())
-                and lib_doc not in (e.library_doc for e in (namespace.get_libraries()).values())
-                and lib_doc not in (e.library_doc for e in (namespace.get_resources()).values())
-            ):
-                return []
-
-            result = set()
-            if include_declaration and kw_doc.source:
-                result.add(Location(str(Uri.from_path(kw_doc.source)), kw_doc.range))
-
             refs = namespace.get_keyword_references()
             if kw_doc in refs:
-                result |= refs[kw_doc]
+                if include_declaration and kw_doc.source == namespace.source:
+                    yield Location(str(Uri.from_path(kw_doc.source)), kw_doc.range)
+
+                yield from refs[kw_doc]
 
-            return list(result)
         except (SystemExit, KeyboardInterrupt, CancelledError):
             raise
         except BaseException as e:
             self._logger.exception(e)
 
-        return []
-
     def has_cached_keyword_references(
         self,
         document: TextDocument,
@@ -346,28 +317,6 @@ def _find_keyword_references(
         include_declaration: bool = True,
         stop_at_first: bool = False,
     ) -> List[Location]:
-        namespace = self.parent.documents_cache.get_namespace(document)
-
-        lib_doc = (
-            next(
-                (
-                    e.library_doc
-                    for e in (namespace.get_libraries()).values()
-                    if kw_doc in e.library_doc.keywords.values()
-                ),
-                None,
-            )
-            or next(
-                (
-                    e.library_doc
-                    for e in (namespace.get_resources()).values()
-                    if kw_doc in e.library_doc.keywords.values()
-                ),
-                None,
-            )
-            or namespace.get_library_doc()
-        )
-
         result = []
 
         if include_declaration and kw_doc.source:
@@ -379,7 +328,6 @@ def _find_keyword_references(
                 stop_at_first,
                 self.find_keyword_references_in_file,
                 kw_doc,
-                lib_doc,
                 False,
             )
         )

packages/robot/src/robotcode/robot/diagnostics/imports_manager.py

@@ -25,6 +25,7 @@
     final,
 )
 
+from robot.utils.text import split_args_from_name_or_path
 from robotcode.core.concurrent import RLock, run_as_task
 from robotcode.core.documents_manager import DocumentsManager
 from robotcode.core.event import event
@@ -603,8 +604,6 @@ def clear_cache(self) -> None:
 
     @_logger.call
     def get_command_line_variables(self) -> List[VariableDefinition]:
-        from robot.utils.text import split_args_from_name_or_path
-
         with self._command_line_variables_lock:
             if self._command_line_variables is None:
                 command_line_vars: List[VariableDefinition] = []