Avoid import of partial defined class. Augment macroeditors tests

Author: HelioGuilherme66

src/robotide/ui/treeplugin.py

@@ -37,7 +37,6 @@
                        RideOpenResource, RideSuiteAdded, RideSelectResource, RideDataFileSet, RideItemNameChanged,
                        RideSaving, RideSettingsChanged)
 from ..controller.ctrlcommands import MoveTo
-from ..controller.filecontrollers import TestDataDirectoryController
 from ..pluginapi import Plugin
 from ..action import ActionInfo
 from ..widgets import PopupCreator
@@ -273,6 +272,7 @@ def on_tree_selection(self, message):
             self._tree.tree_node_selected(message.item)
 
     def on_saving(self, message):
+        from ..controller.filecontrollers import TestDataDirectoryController
         if not isinstance(message.datafile, TestDataDirectoryController):
             return
         # Saving a directory's __init__.robot invalidates every controller, so the whole

utest/editor/test_macroeditors.py

@@ -20,10 +20,35 @@
 # if not DISPLAY:
 #     pytest.skip("Skipped because of missing DISPLAY", allow_module_level=True) # Avoid failing unit tests in system without X11
 import wx
+
+import robotide.editor.editors
 from .fakeplugin import FakePlugin
 from robotide.controller.macrocontrollers import TestCaseController
-from robotide.editor.macroeditors import TestCaseEditor
+from robotide.publish.messages import RideItemNameChanged
+from robotide.editor.editors import FindUsagesHeader
+from robotide.editor.macroeditors import TestCaseEditor, UserKeywordEditor
 
+DELEGATED_METHODS =[('save', 'save'),
+             # ('undo', 'on_undo'),  # Disabled because of double Ctrl-Z
+             ('redo', 'on_redo'),
+             ('cut', 'on_cut'),
+             ('copy', 'on_copy'),
+             ('paste', 'on_paste'),
+             ('insert', 'on_insert'),
+             ('insert_cells', 'on_insert_cells'),
+             ('insert_rows', 'on_insert_rows'),
+             ('delete_rows', 'on_delete_rows'),
+             ('delete_cells', 'on_delete_cells'),
+             ('delete', 'on_delete'),
+             ('show_content_assist', 'show_content_assist'),
+             ('on_move_rows_up', 'on_move_rows_up'),
+             ('on_move_rows_down', 'on_move_rows_down'),
+             ('comment_rows', 'on_comment_rows'),
+             ('uncomment_rows', 'on_uncomment_rows'),
+             ('sharp_comment_rows', 'on_sharp_comment_rows'),
+             ('sharp_uncomment_rows', 'on_sharp_uncomment_rows'),
+             ('comment_cells', 'on_comment_cells'),
+             ('uncomment_cells', 'on_uncomment_cells')]
 
 TestCaseEditor._populate = lambda self: None
 
@@ -60,33 +85,70 @@ class MacroEditorTest(unittest.TestCase):
 
     def setUp(self):
         myapp = wx.App(None)
-        controller = TestCaseController(IncredibleMock(), IncredibleMock())
-        plugin = FakePlugin({}, controller)
+        self.controller = TestCaseController(IncredibleMock(), IncredibleMock())
+        plugin = FakePlugin({}, self.controller)
         self.tc_editor = TestCaseEditor(
-            plugin, wx.Frame(None), controller, None)
+            plugin, wx.Frame(None), self.controller, None)
 
     def test_delegation_to_kw_editor(self):
-        for method, kw_method in \
-            [('save', 'save'),
-             # ('undo', 'on_undo'),  # Disabled because of double Ctrl-Z
-             ('redo', 'on_redo'),
-             ('cut', 'on_cut'),
-             ('copy', 'on_copy'),
-             ('paste', 'on_paste'),
-             ('insert', 'on_insert'),
-             ('insert_cells', 'on_insert_cells'),
-             ('insert_rows', 'on_insert_rows'),
-             ('delete_rows', 'on_delete_rows'),
-             ('delete_cells', 'on_delete_cells'),
-             ('delete', 'on_delete'),
-             ('show_content_assist', 'show_content_assist')]:
+        for method, kw_method in DELEGATED_METHODS:
+            kw_mock = MockKwEditor()
+            self.tc_editor.kweditor = kw_mock
+            getattr(kw_mock, kw_method).is_to_be_called()
+            getattr(self.tc_editor, method)()
+            assert getattr(kw_mock, kw_method).has_been_called(), (f"Should have called \""
+                                                                   f"{kw_method}\" when calling \"{method}\"")
+
+        self.tc_editor._populate()
+        RideItemNameChanged(item=self.controller, old_name='Title of User Keyword', new_name="New Name").publish()
+        # self.tc_editor._name_changed(message)
+        # print(f"DEBUG: Name={self.tc_editor.header}")
+        # assert self.tc_editor.title == "New Name"
+
+
+class MacroEditorUserKWTest(unittest.TestCase):
+
+    def setUp(self):
+        myapp = wx.App(None)
+        self.controller = TestCaseController(IncredibleMock(), IncredibleMock())
+        plugin = FakePlugin({}, self.controller)
+        self.tc_editor = UserKeywordEditor(
+            plugin, wx.Frame(None), self.controller, None)
+
+    def test_delegation_to_kw_editor(self):
+        for method, kw_method in DELEGATED_METHODS:
             kw_mock = MockKwEditor()
             self.tc_editor.kweditor = kw_mock
             getattr(kw_mock, kw_method).is_to_be_called()
             getattr(self.tc_editor, method)()
             assert getattr(kw_mock, kw_method).has_been_called(), (f"Should have called \""
                                                                    f"{kw_method}\" when calling \"{method}\"")
 
+    def test_header(self):
+        myapp = wx.App(None)
+        kw_mock = MockKwEditor()
+        self.tc_editor.kweditor = kw_mock
+        header = self.tc_editor._create_header(text="Title of User Keyword", readonly=False)
+        assert isinstance(header, FindUsagesHeader)
+        label = header._header.GetLabel()
+        assert label == "Title of User Keyword"
+
+    def test_header_read_only(self):
+        myapp = wx.App(None)
+        kw_mock = MockKwEditor()
+        self.tc_editor.kweditor = kw_mock
+        header = self.tc_editor._create_header(text="Title of User Keyword", readonly=True)
+        assert isinstance(header, FindUsagesHeader)
+        label = header._header.GetLabel()
+        assert label == "Title of User Keyword (READ ONLY)"
+
+    def test_misc(self):
+        myapp = wx.App(None)
+        kw_mock = MockKwEditor()
+        self.tc_editor.kweditor = kw_mock
+        self.tc_editor.undo()   # Should do nothing
+        self.tc_editor.close()
+
 
 if __name__ == '__main__':
     app = wx.App()