Skip to content

Commit 2865872

Browse files
committed
[roottest] use fixtures in meta/MakeProject
Configure missing stltest2.ref file Remove unused teststl.ref
1 parent 63fd1ef commit 2865872

File tree

4 files changed

+28
-162
lines changed

4 files changed

+28
-162
lines changed

roottest/root/meta/MakeProject/.rootrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

roottest/root/meta/MakeProject/CMakeLists.txt

Lines changed: 28 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
1-
ROOTTEST_GENERATE_DICTIONARY(stl_makeproject_test stl_makeproject_test.h LINKDEF stl_makeproject_test_linkdef.h NO_ROOTMAP NO_CXXMODULE)
1+
ROOTTEST_GENERATE_DICTIONARY(stl_makeproject_test
2+
stl_makeproject_test.h
3+
LINKDEF stl_makeproject_test_linkdef.h
4+
NO_ROOTMAP NO_CXXMODULE
5+
FIXTURES_SETUP root-meta-MakeProject-stl_makeproject_test-fixture)
26
# If we build roottest in-tree, add a dependecy on Hist because the header
37
# includes TH1D.
48
if(TARGET Hist)
59
add_dependencies(stl_makeproject_test Hist)
610
endif()
711

8-
if(ROOT_runtime_cxxmodules_FOUND)
9-
# FIXME: For C++ modules builds, module.modulemap is generated during configuration time
12+
if(runtime_cxxmodules)
13+
# FIXME: For C++ modules builds, module.modulemap is generated during configuration time
1014
# and it is not needed during execution of stltest*, but later for other tests it needs to be back in build directory.
1115
# FIXME: We need to run some tests in serial mode, because in very-parallel builds,
1216
# since they access the same build directory, they could conflict via existent/not module.modulemap file.
@@ -18,8 +22,7 @@ if(ROOT_runtime_cxxmodules_FOUND)
1822
OUTCNV atlasaod_convert.sh
1923
OUTREF atlasaod.ref
2024
LABELS longtest
21-
RUN_SERIAL
22-
)
25+
RUN_SERIAL)
2326

2427
ROOTTEST_ADD_TEST(runcms310
2528
COPY_TO_BUILDDIR enable_modulemap.sh
@@ -39,34 +42,35 @@ if(ROOT_runtime_cxxmodules_FOUND)
3942
OUTCNV aliceesd_convert.sh
4043
OUTREF aliceesd.ref
4144
RUN_SERIAL)
42-
45+
4346
ROOTTEST_ADD_TEST(examples
44-
COPY_TO_BUILDDIR enable_modulemap.sh
47+
COPY_TO_BUILDDIR enable_modulemap.sh disable_modulemap.sh stl_makeproject_test.h
4548
PRECMD ./enable_modulemap.sh ${CMAKE_CURRENT_BINARY_DIR}
46-
COPY_TO_BUILDDIR stl_makeproject_test.h
4749
MACRO create_makeproject_examples.C
4850
OUTREF create_makeproject_examples.ref
49-
DEPENDS ${GENERATE_DICTIONARY_TEST} stl_makeproject_test-build)
51+
FIXTURES_REQUIRED root-meta-MakeProject-stl_makeproject_test-fixture
52+
FIXTURES_SETUP root-meta-MakeProject-examples-fixture)
5053

5154
ROOTTEST_ADD_TEST(stltest
52-
COPY_TO_BUILDDIR disable_modulemap.sh enable_modulemap.sh
5355
PRECMD ./disable_modulemap.sh ${CMAKE_CURRENT_BINARY_DIR}
5456
MACRO runstltest.C
5557
POSTCMD ./enable_modulemap.sh ${CMAKE_CURRENT_BINARY_DIR}
5658
OUTREF teststlCTEST.ref
57-
DEPENDS examples)
59+
FIXTURES_REQUIRED root-meta-MakeProject-examples-fixture
60+
FIXTURES_SETUP root-meta-MakeProject-stltest-fixture)
5861

5962
ROOTTEST_ADD_TEST(stltest2
60-
COPY_TO_BUILDDIR disable_modulemap.sh enable_modulemap.sh
6163
PRECMD ./disable_modulemap.sh ${CMAKE_CURRENT_BINARY_DIR}
6264
MACRO runstltest2.C
6365
POSTCMD ./enable_modulemap.sh ${CMAKE_CURRENT_BINARY_DIR}
64-
DEPENDS stltest)
66+
OUTREF stltest2.ref
67+
FIXTURES_REQUIRED root-meta-MakeProject-stltest-fixture)
6568

6669
ROOTTEST_ADD_TEST(foreign
6770
COPY_TO_BUILDDIR enable_modulemap.sh foreign.root
6871
PRECMD ./enable_modulemap.sh ${CMAKE_CURRENT_BINARY_DIR}
6972
MACRO runforeign.C
73+
OUTREF foreign.ref
7074
RUN_SERIAL)
7175
else()
7276
ROOTTEST_ADD_TEST(runatlasaod
@@ -88,24 +92,28 @@ else()
8892
MACRO runaliceesd.C
8993
OUTCNV aliceesd_convert.sh
9094
OUTREF aliceesd.ref)
91-
95+
9296
ROOTTEST_ADD_TEST(examples
9397
COPY_TO_BUILDDIR stl_makeproject_test.h
9498
MACRO create_makeproject_examples.C
9599
OUTREF create_makeproject_examples.ref
96-
DEPENDS ${GENERATE_DICTIONARY_TEST} stl_makeproject_test-build)
100+
FIXTURES_REQUIRED root-meta-MakeProject-stl_makeproject_test-fixture
101+
FIXTURES_SETUP root-meta-MakeProject-examples-fixture)
97102

98103
ROOTTEST_ADD_TEST(stltest
99104
MACRO runstltest.C
100105
OUTREF teststlCTEST${ref_suffix}
101-
DEPENDS examples)
102-
106+
FIXTURES_REQUIRED root-meta-MakeProject-examples-fixture
107+
FIXTURES_SETUP root-meta-MakeProject-stltest-fixture)
108+
103109
ROOTTEST_ADD_TEST(stltest2
104110
MACRO runstltest2.C
105-
DEPENDS stltest)
111+
OUTREF stltest2.ref
112+
FIXTURES_REQUIRED root-meta-MakeProject-stltest-fixture)
106113

107114
ROOTTEST_ADD_TEST(foreign
108-
COPY_TO_BUILDDIR foreign.root
109-
MACRO runforeign.C)
115+
COPY_TO_BUILDDIR foreign.root
116+
MACRO runforeign.C
117+
OUTREF foreign.ref)
110118
endif()
111119

roottest/root/meta/MakeProject/Makefile

Lines changed: 0 additions & 134 deletions
This file was deleted.

roottest/root/meta/MakeProject/teststl.ref

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)