Publish all castable data types to pal_statistics #2633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
the
backport-kilted
github-actions
bot
requested review from
LukasMacha97,
VX792,
bijoua29,
destogl,
livanov93,
saikishor and
xguay
destogl
reviewed
Nov 12, 2025
| * @throw std::runtime_error if the HandleDataType cannot be casted to double. | ||
| * @note Once we add support for more data types, this function should be updated | ||
| */ | ||
| double cast_to_double(const HANDLE_DATATYPE & value) const |
Member
There was a problem hiding this comment.
I find this good! We will also need this for reuse of controllers.
Also do backwards casting from double to internal values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle types not being double are just not published now.
I tried to make cast_to_double() reusable, I did not find a better place to add it.