Use Objective-Git to check ref validity

rowanj · rowanj · commit 2ee72c9dc978 · 2013-08-18T20:42:29.000+10:00
Continuing work on issue #2
diff --git a/Classes/git/PBGitRepository.m b/Classes/git/PBGitRepository.m
@@ -453,11 +453,8 @@ - (BOOL)isRefOnHeadBranch:(PBGitRef *)testRef
 
 - (BOOL) checkRefFormat:(NSString *)refName
 {
-	int retValue = 1;
-	[self outputInWorkdirForArguments:[NSArray arrayWithObjects:@"check-ref-format", refName, nil] retValue:&retValue];
-	if (retValue)
-		return NO;
-	return YES;
+	BOOL result = [GTReference isValidReferenceName:refName];
+	return result;
 }
 
 - (BOOL) refExists:(PBGitRef *)ref

Original file line number	Diff line number	Diff line change
`@@ -453,11 +453,8 @@ - (BOOL)isRefOnHeadBranch:(PBGitRef *)testRef`
`453`	`453`
`454`	`454`	`- (BOOL) checkRefFormat:(NSString *)refName`
`455`	`455`	`{`
`456`		`- int retValue = 1;`
`457`		`- [self outputInWorkdirForArguments:[NSArray arrayWithObjects:@"check-ref-format", refName, nil] retValue:&retValue];`
`458`		`- if (retValue)`
`459`		`- return NO;`
`460`		`- return YES;`
	`456`	`+ BOOL result = [GTReference isValidReferenceName:refName];`
	`457`	`+ return result;`
`461`	`458`	`}`
`462`	`459`
`463`	`460`	`- (BOOL) refExists:(PBGitRef *)ref`