Support for Rails 7.2

[dwarner]

I know 7.1.0 just got released with support for Rails 7.1.x (thanks), but is there an ETA for Rails 7.2 support?

https://github.com/rsim/oracle-enhanced/blob/v7.1.0/activerecord-oracle_enhanced-adapter.gemspec
s.add_runtime_dependency("activerecord", ["~> 7.1.0"])

I know Rails 7.2 ActiveRecord has a lot of "Remove deprecated" . . .
https://guides.rubyonrails.org/7_2_release_notes.html#active-record

[numbcoder]

+1

[matthewkrom]

+1

[rjschof]

+1. Any updates on this or any sort of plans to maintain this gem?

[andynu]

I started attempting to upgrade to 7.2, and got stuck. #2422
Anyone willing to give my very limited progress a look, I'd appreciate additional perspectives and/or suggestions for diagnosing.

[andynu]

I've made further progress and cut a new PR for consideration. Not all the way there, but a significant step closer. There are now only four remaining test failures locally. #2424

[dwarner]

@andynu Thanks for your hard work!

We've pulled your 7.2 branch into one of our projects and have NOT run into a problem.

We'll be trying it on other projects coming up.

Do you have an ETA on an official release?

[andynu]

Hi Dennis, I'm glad the patch has been working well for you, and me too! Alas, I am just a random user; I have no access to make releases.

…

On Thu, May 15, 2025 at 9:53 AM Dennis Warner ***@***.***> wrote: *dwarner* left a comment (rsim/oracle-enhanced#2411) <#2411 (comment)> @andynu <https://github.com/andynu> Thanks for your hard work! We've pulled your 7.2 branch into one of our projects and have NOT run into a problem. We'll be trying it on other projects coming up. Do you have an ETA on an official release? — Reply to this email directly, view it on GitHub <#2411 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAONGOKA4PBXVOD5VMUTKL26SL4PAVCNFSM6AAAAABPMKZDQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBTHA4TQNBZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[akostadinov]

Whoever tested this, maybe you add an approval so hopefully author attention is captured.

[joshRpowell]

@andynu Thanks for your hard work!

We've pulled your 7.2 branch into one of our projects and have NOT run into a problem.

We'll be trying it on other projects coming up.

Do you have an ETA on an official release?

+1 branch has been running in app ~6mo now. No issues.
Thanks for all your work @andynu 🥳
(unfortunately, not able to approve)

[dwarner]

@andynu I will make a comment on the PR.

Have you gotten any responses/feedback from the maintainers?

[andynu]

Nope

…

On May 15 2025, at 12:37 pm, Dennis Warner ***@***.***> wrote: dwarner left a comment (rsim/oracle-enhanced#2411) (#2411 (comment)) @andynu (https://github.com/andynu) I will make a comment on the PR. Have you gotten any responses/feedback from the maintainers? — Reply to this email directly, view it on GitHub (#2411 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAAONGNDVP553PICVGFRSRT26S7GPAVCNFSM6AAAAABPMKZDQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBUGQ2DENBQGY). You are receiving this because you were mentioned.

[dwarner]

@rsim Are you still maintaining this project?

[smarks-1-ND]

Yes, thank you @andynu . I am testing your branch now and things are looking good. Hoping this can be merged soon.

[Bjoernsen]

Thank you @andynu ! I have a quite complex gem that connects to different databases.

Most of my tests worked out of the box with 7.2. Only one test failed. I am not sure if this is a Rails 7.2 behavior, a bug in the adapter, or if I do not know what I am doing.

In my gem, I have a method calling something like

SomeValue.where('value BETWEEN ? and ?', min, max)

The values for min and max come from another DB call. In 7.1 it works, in 7.2 I get the error ActiveRecord::StatementInvalid: OCIError: ORA-01722: invalid number

The issue is that min and max can be a BigDecimal (e.g. 0.23255e3).

The solution was to add .to_f to the variables.

SomeValue.where('value BETWEEN ? and ?', min.to_f, max.to_f)