Care about constraint alias of add_constraint

Author: numbata

lib/rubocop/cop/sequel/not_valid_constraint.rb

@@ -6,10 +6,10 @@ module Sequel
       # Constraint created without not_valid option
       class NotValidConstraint < Base
         MSG = 'Prefer creating new constraint with the `not_valid: true` option.'
-        RESTRICT_ON_SEND = %i[add_foreign_key add_constraint].freeze
+        RESTRICT_ON_SEND = %i[add_foreign_key constraint add_constraint].freeze
 
         def_node_matcher :add_constraint_without_not_valid?, <<-MATCHER
-          (send _ {:add_foreign_key :add_constraint} $...)
+          (send _ {:add_foreign_key :constraint :add_constraint} $...)
         MATCHER
 
         def on_send(node)

spec/rubocop/cop/sequel/not_valid_constraint_spec.rb

@@ -5,30 +5,60 @@
 describe RuboCop::Cop::Sequel::NotValidConstraint do
   subject(:cop) { described_class.new }
 
-  it 'registers an offense when add_constraint used without valid option' do
-    offenses = inspect_source(<<~RUBY)
-      add_constraint :not_valid, Sequel.lit("jsonb_typeof(column) = 'object'")
-      add_constraint({name: "not_valid"}, Sequel.lit("jsonb_typeof(column) = 'object'"))
-    RUBY
+  context 'when add_constraint used' do
+    it 'registers an offense when used without `not_valid: true` option' do
+      offenses = inspect_source(<<~RUBY)
+        add_constraint :not_valid, Sequel.lit("jsonb_typeof(column) = 'object'")
+        add_constraint({name: "not_valid"}, Sequel.lit("jsonb_typeof(column) = 'object'"))
+      RUBY
 
-    expect(offenses.size).to eq(2)
+      expect(offenses.size).to eq(2)
+    end
+
+    it 'does not register an offense when using `not_valid: true` option' do
+      offenses = inspect_source(<<~RUBY)
+        add_constraint({name: "name", not_valid: true }, Sequel.lit("jsonb_typeof(column) = 'object'"))
+      RUBY
+
+      expect(offenses.size).to eq(0)
+    end
   end
 
-  it 'registers an offense when add_foregn_key used without valid option' do
-    offenses = inspect_source(<<~RUBY)
-      add_foreign_key(:not_valid, :table)
-      add_foreign_key(:not_valid, :table, name: "not_valid")
-    RUBY
+  context 'when constraint used' do
+    it 'registers an offense when used without `not_valid: true` option' do
+      offenses = inspect_source(<<~RUBY)
+        constraint :not_valid, Sequel.lit("jsonb_typeof(column) = 'object'")
+        constraint({name: "not_valid"}, Sequel.lit("jsonb_typeof(column) = 'object'"))
+      RUBY
+
+      expect(offenses.size).to eq(2)
+    end
 
-    expect(offenses.size).to eq(2)
+    it 'does not register an offense when using `not_valid: true` option' do
+      offenses = inspect_source(<<~RUBY)
+        constraint({name: "name", not_valid: true }, Sequel.lit("jsonb_typeof(column) = 'object'"))
+      RUBY
+
+      expect(offenses.size).to eq(0)
+    end
   end
 
-  it 'does not register an offense when using not valid option' do
-    offenses = inspect_source(<<~RUBY)
-      add_constraint({name: "name", not_valid: true }, Sequel.lit("jsonb_typeof(column) = 'object'"))
-      add_foreign_key(:not_valid, :table, name: "not_valid", not_valid: true)
-    RUBY
+  context 'when add_foreign_key used' do
+    it 'registers an offense when used without `not_valid: true` option' do
+      offenses = inspect_source(<<~RUBY)
+        add_foreign_key(:not_valid, :table)
+        add_foreign_key(:not_valid, :table, name: "not_valid")
+      RUBY
+
+      expect(offenses.size).to eq(2)
+    end
+
+    it 'does not register an offense when using `not_valid: true` option' do
+      offenses = inspect_source(<<~RUBY)
+        add_foreign_key(:not_valid, :table, name: "not_valid", not_valid: true)
+      RUBY
 
-    expect(offenses.size).to eq(0)
+      expect(offenses.size).to eq(0)
+    end
   end
 end