Skip to content

Conversation

@Lord-McSweeney
Copy link
Collaborator

This moves the files utils.rs, sandbox.rs, buffer.rs, tag_utils.rs, and xml.rs to ruffle_common. These files don't contain any hot code that might not be inlined after this change, so this is probably fine performance-wise. Moving SwfMovie to ruffle_common is necessary for splitting AVM2 into its own crate.

@Lord-McSweeney Lord-McSweeney added waiting-on-review Waiting on review from a Ruffle team member A-core Area: Core player, where no other category fits T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Nov 7, 2025
@Lord-McSweeney Lord-McSweeney force-pushed the more-common branch 2 times, most recently from edd6c0e to 151ccc5 Compare November 7, 2025 01:55
@moulins
Copy link
Contributor

moulins commented Nov 7, 2025

I'm not entirely convinced by the tag_utils move: I don't like how it makes ruffle_common depend on ruffle_render and ttf_parser just to be able to include their error types as tag_utils::Error variants. Couldn't we move only SwfMovie into ruffle_common and leave the rest of the tag_utils logic in ruffle_core?

@Lord-McSweeney Lord-McSweeney marked this pull request as draft November 7, 2025 16:02
@Lord-McSweeney Lord-McSweeney force-pushed the more-common branch 2 times, most recently from c94b036 to 0e7a6c2 Compare November 7, 2025 19:11
@Lord-McSweeney Lord-McSweeney marked this pull request as ready for review November 7, 2025 19:11
@Lord-McSweeney Lord-McSweeney merged commit 3641069 into ruffle-rs:master Nov 9, 2025
26 checks passed
@Lord-McSweeney Lord-McSweeney removed the waiting-on-review Waiting on review from a Ruffle team member label Nov 9, 2025
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Nov 16, 2025
--------------------------------------------------------------------------------------------------------
batocera-emulationstation.mk aea07f8c688c21cdef3549d3f77c6fa6aa97eb52 # Version: Commits on Nov 10, 2025
--------------------------------------------------------------------------------------------------------
Merge pull request #2007 from fabricecaruso/win

Misc things,

------------------------------------------------------------------------------------------------
batocera-es-piboy.mk aea07f8c688c21cdef3549d3f77c6fa6aa97eb52 # Version: Commits on Nov 10, 2025
------------------------------------------------------------------------------------------------
Merge pull request #2007 from fabricecaruso/win

Misc things,

---------------------------------------------------------------------------------------
amiberry.mk 3f03539b49795b0215fd273ab0858f72fffcfca9 # Version: Commits on Nov 10, 2025
---------------------------------------------------------------------------------------
enhancement: Improve OpenGL context initialization and logging for better compatibility,

------------------------------------------------------------------------------------------
dolphin-emu.mk ac62efaf9233c9c16f6636038d0c2a3c44ac3988 # Version: Commits on Nov 10, 2025
------------------------------------------------------------------------------------------
Merge pull request #14088 from SuperSamus/spiderman-wos-singlecore

GameINI: Disable Dual Core for Spider-Man: Web of Shadows,

-----------------------------------------------------------------------------------
eden.mk 42863027e2c4be40da79b7bfabdecc47d0494486 # Version: Commits on Nov 09, 2025
-----------------------------------------------------------------------------------
Revert "[core/memory] Remove defered heap allocation on Linux." (#2974)

--------------------------------------------------------------------------------------
flycast.mk b1489d665e4813a0879a5fdf79899177aa7434d2 # Version: Commits on Nov 10, 2025
--------------------------------------------------------------------------------------
[Libretro] Update AV info when switching a PAL game to 60Hz,

--------------------------------------------------------------------------------------
openmsx.mk 8e53b2dd18505e5d94dd892d67cbd9db3ac31c2d # Version: Commits on Nov 09, 2025
--------------------------------------------------------------------------------------
Fix wrong error message 'Invalid external slot specification for ps=1 ss=-1'

See: openMSX/openMSX#2028

This is a new error message introduced in 244d8def8b.

It triggered when loading a savestate (possibly an in-memory savestate

for reverse). And it's caused by restoring the 'type' field too late

(only after calling parseSlots()). Before this order didn't matter.,

-------------------------------------------------------------------------------------
ppsspp.mk fd300aeb23bb49f68d5efde1bcd28b3995fd6167 # Version: Commits on Nov 10, 2025
-------------------------------------------------------------------------------------
Merge pull request #20986 from hrydgard/guess-what-more-ui

More UI improvements for portrait,

------------------------------------------------------------------------------------
rpcs3.mk 2fb8cbda385028ab5cf465623badd5dd08b25032 # Version: Commits on Nov 10, 2025
------------------------------------------------------------------------------------
SaveStates/ZSTD: Improve termination and file handling,

-----------------------------------------------------
ryujinx.mk 1.3.213 # Version: Commits on Nov 10, 2025
-----------------------------------------------------
Canary-1.3.213

--------------------------------------------------------------------------------------
shadps4.mk ee2bc97248f460670e982f7966a70c092c896676 # Version: Commits on Nov 10, 2025
--------------------------------------------------------------------------------------
Windows: Limit address space maximum when higher addresses are not needed (#3775)

* Earlier initialization of elf info.

Everything used for elf info initialization comes from the param.sfo, so we can initialize this earlier to have this information accessible during memory init.

* Extract compiled SDK version from pubtoolinfo string

Up until now, we've been using the game's reported \firmware version\ as our compiled SDK version. This behavior is inaccurate, and is something that has come up in my hardware tests before.

For the actual compiled SDK version, we should use the SDK version in the PUBTOOLINFO string of the param.sfo, only falling back on the firmware version when that the sdk_ver component isn't present.

* Store compiled SDK version in ElfInfo

* Limit address space for compiled SDK version at or above FW 3

Sony placed a hard cap at 0xfc00000000, with a slight extension for stack mappings. For now, though stack mappings aren't implemented, there's no harm in keeping a slightly extended address space (since this cap is lower than our old user max).

Limiting the max through address space is necessary for Windows due to performance issues, in the future I plan to properly implement checks in memory manager code to properly handle this behavior for all platforms.

* Use compiled SDK version for sceKernelGetCompiledSdkVersion

I think this is pretty self explanatory.

* Log SDK version

Since this value is what most internal firmware version checks are against, logging the value will help with debugging.

* Update address_space.cpp

* Update emulator.cpp

* Backwards compatible logging

Because that's apparently an issue now,

---------------------------------------------------
xemu.mk v0.8.113 # Version: Commits on Nov 10, 2025
---------------------------------------------------
null

-------------------------------------------------------------------------------------------
xenia-native.mk 68b3490c8bdb2a819e80b113457aa16c6634118e # Version: Commits on Nov 09, 2025
-------------------------------------------------------------------------------------------
[Kernel] Fixed invalid address of a native object pointer,

---------------------------------------------------------------
ruffle.mk nightly-2025-11-10 # Version: Commits on Nov 10, 2025
---------------------------------------------------------------
## What's Changed

* chore: Move more `ruffle_core` code to new `ruffle_common` crate by @Lord-McSweeney in ruffle-rs/ruffle#22163

* chore: Migrate crates to Rust Edition 2024 (part 3/N) by @moulins in ruffle-rs/ruffle#22183

* core/avm1/avm2: Minor fixes to DO lookup, naming, and construction by @Lord-McSweeney in ruffle-rs/ruffle#22170

* chore: Migrate crates to Rust Edition 2024 (part 4/N) by @moulins in ruffle-rs/ruffle#22186

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-11-09...nightly-2025-11-10,

-----------------------------------------------------------------------------------------
rpi-eeprom.mk c6a755543ee058d9487ce3c495de5da0675fd7a3 # Version: Commits on Nov 10, 2025
-----------------------------------------------------------------------------------------
imager: Move the imager release to 2025-11-05,

----------------------------------------------------------------------------------------
pironman5.mk f1a4b9d046e8459e48424e4a7c25e2ada5dc1cf5 # Version: Commits on Nov 10, 2025
----------------------------------------------------------------------------------------
delete batocera,

------------------------------------------------------------------------------------
box64.mk 94c7dd57966646e919504dcdc6ba5b69de4c6e05 # Version: Commits on Nov 10, 2025
------------------------------------------------------------------------------------
[LA64_DYNAREC] Added more opcodes (#3158),

-----------------------------------------------------------------------------------------
catacombgl.mk 05ed62fd52fddcf9f78dea147994e048a8177df0 # Version: Commits on Nov 10, 2025
-----------------------------------------------------------------------------------------
Merge pull request #67 from carlo-bramini/fix-gcc15-build

Fix build with GCC15 and Woa64,

---------------------------------------------------------------------------------------
corsixth.mk 14b98d7621ea0c6b631ea04225085fd565940d2a # Version: Commits on Nov 10, 2025
---------------------------------------------------------------------------------------
Merge pull request #3109 from lewri/remove_correct_diagroom

Remove the correct diagnosis room,

---------------------------------------------------------------------------------------
etlegacy.mk 03e91927a510bc23ab764e2d319ccc197d4f99a1 # Version: Commits on Nov 10, 2025
---------------------------------------------------------------------------------------
cgame: add [nol] syntax to disable loc in tchat,

----------------------------------------------------------------------------------------
openmohaa.mk 94328af9b1c258566959426ec36ab138d74731b9 # Version: Commits on Nov 09, 2025
----------------------------------------------------------------------------------------
fix(cgame): fix attached entities not being able to emit a light correctly (#825)

Attached entities don't have an origin (0,0,0) so a light would be emitted at the null origin.,

-----------------------------------------------------------------------------------
rott.mk 03d8d7f2f800c158eeb28b560844f663132d01ab # Version: Commits on Nov 10, 2025
-----------------------------------------------------------------------------------
be more careful with releasing resources,

--------------------------------------------------------------------------------------
stalker.mk 29d47347429af992ed1483a3cc55988eaaaaa13a # Version: Commits on Nov 10, 2025
--------------------------------------------------------------------------------------
build(deps): bump Externals/imgui from `1d942eb` to `3109131` (#1985)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>,

---------------------------------------------------------------------------------------
mangohud.mk d4ac646440f8733e97cd83ce4ed64ef122fcd8c0 # Version: Commits on Oct 27, 2025
---------------------------------------------------------------------------------------
gl: track the GL contexts and the resources that depend on them together

While at it, only create and initialize the overlay from

{glX|egl}SwapBuffers().

Also default gl_bind_framebuffer parameter to 0: we basically always

want to draw to the system framebuffer.,

-------------------------------------------------------------------------------------------------
libretro-core-info.mk 436258b3efe90bf1394a43486d5cb67e4550ad93 # Version: Commits on Nov 10, 2025
-------------------------------------------------------------------------------------------------
v1.22.0,

----------------------------------------------------------------------------------------
retroarch.mk 11018c8356687147c013628ddac045d5b49c6a25 # Version: Commits on Nov 10, 2025
----------------------------------------------------------------------------------------
Warning fix,

-----------------------------------------------------------------------------------------------
retroarch-assets.mk 76cc6cf03507429c5a136cb50d83a14e05430fcd # Version: Commits on Nov 10, 2025
-----------------------------------------------------------------------------------------------
Merge pull request #489 from mittonk/inkscape_flags

Update inkscape file input/output args.,

----------------------------------------------------------------------------------------
doomretro.mk 9f8c072667c22bdb823dc4d2a2ed92ee148f9236 # Version: Commits on Nov 10, 2025
----------------------------------------------------------------------------------------
Update releasenotes.md,

----------------------------------------------------------------------------------
trx.mk bb4ad0246989a4ff6ad5668c49adb89d6e46a912 # Version: Commits on Nov 10, 2025
----------------------------------------------------------------------------------
docs: update,

-----------------------------------------------------------------------------------------------
libretro-flycast.mk b1489d665e4813a0879a5fdf79899177aa7434d2 # Version: Commits on Nov 10, 2025
-----------------------------------------------------------------------------------------------
[Libretro] Update AV info when switching a PAL game to 60Hz,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk fd300aeb23bb49f68d5efde1bcd28b3995fd6167 # Version: Commits on Nov 10, 2025
----------------------------------------------------------------------------------------------
Merge pull request #20986 from hrydgard/guess-what-more-ui

More UI improvements for portrait,

-------------------------------------------------------------------------------------------
libretro-ps2.mk 657a088618d1bafed097545a542eb2e669ae1dd2 # Version: Commits on Nov 10, 2025
-------------------------------------------------------------------------------------------
microVU: backport 'fix ASAN container-overflow in mVUsetupRange'

and 'fix block clearing regression',

---------------------------------------------------------------------------------------------
libretro-vba-m.mk 601f0ac076deaed81af61dffbd4708da9cf5cdc0 # Version: Commits on Nov 09, 2025
---------------------------------------------------------------------------------------------
Fix MSVC unreachable code warnings in release

Followup on b431e601 (Fix MSVC warnings from `VBAM_NOTREACHED()` macro,

2025-11-09) try to fix the MSVC unreachable code warnings in release

builds again.

Fixed with Claude.

Signed-off-by: Rafael Kitover <[email protected]>,

--------------------------------------------------------------------------------------------
slang-shaders.mk a1baec12da339730f90fb18041c364163865875e # Version: Commits on Nov 10, 2025
--------------------------------------------------------------------------------------------
Add \Black Lightening\ parameter (#792)

* Start loop from the center and apply tab size when count is larger limit

* Extract shared blur code into separate file

* Move content of slangp into crt-yah folder referenced by original file

* Add \Black Lightening\ parameter,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-core Area: Core player, where no other category fits T-chore Type: Chore (like updating a dependency, it's gotta be done)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants