Skip to content

Commit 38538c0

Browse files
committed
Remove path dev-dependency
Currently we are enabling "rand" using a path dependency in the dev-dependencies because of the benches. This is reducing coverage in CI because "std" is always enabled. Feature gate the bench that requires "rand" and remove the path dependency.
1 parent 5bb4711 commit 38538c0

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ bitcoin_hashes = { version = ">=0.12, <=0.13", default-features = false }
5353
unicode-normalization = { version = "0.1.22", default-features = false, optional = true }
5454

5555
[dev-dependencies]
56-
# Enabling the "rand" feature by default to run the benches
57-
bip39 = { path = ".", features = ["rand"] }
5856
bitcoin_hashes = ">=0.12,<0.14" # enable default features for test
5957

6058

benches/bench.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ fn from_entropy(b: &mut Bencher) {
5959
});
6060
}
6161

62+
#[cfg(feature = "rand")]
6263
#[bench]
6364
fn new_mnemonic(b: &mut Bencher) {
6465
b.iter(|| {

0 commit comments

Comments
 (0)