fix some clippy warnings

Signed-off-by: Adrian Catangiu <[email protected]>

Author: acatangiu

src/ioctls/device.rs

@@ -100,7 +100,7 @@ mod tests {
 
         let dist_attr = kvm_bindings::kvm_device_attr {
             group: KVM_DEV_VFIO_GROUP,
-            attr: KVM_DEV_VFIO_GROUP_ADD as u64,
+            attr: u64::from(KVM_DEV_VFIO_GROUP_ADD),
             addr: 0x0,
             flags: 0,
         };

src/ioctls/mod.rs

@@ -49,7 +49,7 @@ impl KvmRunWrapper {
     /// # Arguments
     /// * `fd` - File descriptor to mmap from.
     /// * `size` - Size of memory region in bytes.
-    pub fn mmap_from_fd(fd: &AsRawFd, size: usize) -> Result<KvmRunWrapper> {
+    pub fn mmap_from_fd(fd: &dyn AsRawFd, size: usize) -> Result<KvmRunWrapper> {
         // This is safe because we are creating a mapping in a place not already used by any other
         // area in this process.
         let addr = unsafe {

src/ioctls/system.rs

@@ -446,7 +446,7 @@ mod tests {
         let kvm = Kvm::new().unwrap();
         let mut cpuid = kvm.get_supported_cpuid(KVM_MAX_CPUID_ENTRIES).unwrap();
         let cpuid_entries = cpuid.as_mut_slice();
-        assert!(cpuid_entries.len() > 0);
+        assert!(!cpuid_entries.is_empty());
         assert!(cpuid_entries.len() <= KVM_MAX_CPUID_ENTRIES);
     }
 
@@ -456,7 +456,7 @@ mod tests {
         let kvm = Kvm::new().unwrap();
         let mut cpuid = kvm.get_emulated_cpuid(KVM_MAX_CPUID_ENTRIES).unwrap();
         let cpuid_entries = cpuid.as_mut_slice();
-        assert!(cpuid_entries.len() > 0);
+        assert!(!cpuid_entries.is_empty());
         assert!(cpuid_entries.len() <= KVM_MAX_CPUID_ENTRIES);
     }
 

src/ioctls/vcpu.rs

@@ -1203,7 +1203,7 @@ mod tests {
             panic!("mmap failed.");
         }
 
-        return addr as *mut u8;
+        addr as *mut u8
     }
 
     #[test]
@@ -1443,7 +1443,7 @@ mod tests {
             // Get a mutable slice of `mem_size` from `load_addr`.
             // This is safe because we mapped it before.
             let mut slice = std::slice::from_raw_parts_mut(load_addr, mem_size);
-            slice.write(&code).unwrap();
+            slice.write_all(&code).unwrap();
         }
 
         let vcpu_fd = vm.create_vcpu(0).unwrap();
@@ -1488,10 +1488,10 @@ mod tests {
                     // * one when the code itself is loaded in memory;
                     // * and one more from the `movl` that writes to address 0x8000
                     let dirty_pages_bitmap = vm.get_dirty_log(slot, mem_size).unwrap();
-                    let dirty_pages = dirty_pages_bitmap
+                    let dirty_pages: u32 = dirty_pages_bitmap
                         .into_iter()
                         .map(|page| page.count_ones())
-                        .fold(0, |dirty_page_count, i| dirty_page_count + i);
+                        .sum();
                     assert_eq!(dirty_pages, 2);
                     break;
                 }
@@ -1573,10 +1573,7 @@ mod tests {
             badf_errno
         );
         assert_eq!(
-            faulty_vcpu_fd
-                .set_msrs(&mut Msrs::new(1))
-                .unwrap_err()
-                .errno(),
+            faulty_vcpu_fd.set_msrs(&Msrs::new(1)).unwrap_err().errno(),
             badf_errno
         );
         assert_eq!(

src/kvm_ioctls.rs

@@ -211,7 +211,7 @@ mod tests {
     use vmm_sys_util::ioctl::{ioctl, ioctl_with_val};
 
     use super::*;
-    const KVM_PATH: &'static str = "/dev/kvm\0";
+    const KVM_PATH: &str = "/dev/kvm\0";
 
     #[test]
     fn get_version() {