refactor: devScripts update (#1540)

* chore: updates from devScripts

* fix: rejiggered eslint.config.mjs (W-23928423)

---------

Co-authored-by: Jamie Feingold <jfeingold@salesforce.com>
Co-authored-by: Willie Ruemmele <willieruemmele@gmail.com>

Author: 3 people

.eslintignore

@@ -0,0 +1,22 @@
+import tsconfigs from 'eslint-config-salesforce-typescript';
+import plugin from 'eslint-plugin-sf-plugin';
+
+const configs = [
+  ...tsconfigs,
+  ...plugin.configs.recommended,
+  {
+    rules: {
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          caughtErrorsIgnorePattern: '^_',
+        },
+      ],
+      'jsdoc/newline-after-description': 'off',
+    },
+  },
+];
+
+export default configs;

.eslintrc.cjs

@@ -21,11 +21,17 @@
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^5.3.20",
     "@salesforce/cli-plugins-testkit": "^5.3.66",
-    "@salesforce/dev-scripts": "^11.0.4",
+    "@salesforce/dev-scripts": "^13.0.2",
     "@salesforce/plugin-command-reference": "^3.1.132",
     "@salesforce/ts-sinon": "^1.4.34",
+    "@types/chai": "^4.3.17",
+    "@types/mocha": "^10.0.10",
+    "@types/node": "^18",
+    "@types/sinon": "^10.0.20",
     "@types/which": "^3",
-    "eslint-plugin-sf-plugin": "^1.20.33",
+    "eslint": "^10.4.0",
+    "eslint-config-salesforce-typescript": "^6.0.0",
+    "eslint-plugin-sf-plugin": "^3.0.0",
     "oclif": "^4.23.16",
     "ts-node": "^10.9.2",
     "typescript": "^5.5.4"
@@ -154,6 +160,7 @@
         "src/**/*.ts",
         "test/**/*.ts",
         "messages/**",
+        "**/eslint.config.*",
         "**/.eslint*",
         "**/tsconfig.json"
       ],

eslint.config.mjs

@@ -77,7 +77,7 @@ export default class ListAuth extends SfCommand<AuthListResults> {
       }
 
       return mappedAuths;
-    } catch (err) {
+    } catch (_err) {
       this.log(messages.getMessage('noResultsFound'));
       return [];
     }

package.json

@@ -95,6 +95,7 @@ export default class LoginJwt extends SfCommand<AuthFields> {
   public async run(): Promise<AuthFields> {
     const { flags } = await this.parse(LoginJwt);
     this.flags = flags;
+    // eslint-disable-next-line no-useless-assignment -- assignment isn't actually useless.
     let result: AuthFields = {};
 
     if (await common.shouldExitCommand(flags['no-prompt'])) return {};

src/commands/org/list/auth.ts

@@ -223,7 +223,7 @@ export default class LoginWeb extends SfCommand<AuthFields> {
   }
 
   // leave it because it's stubbed in the test
-  // eslint-disable-next-line class-methods-use-this
+   
   private async executeLoginFlow({
     oauthConfig,
     browser,

src/commands/org/login/jwt.ts

@@ -94,6 +94,7 @@ type NpmExplanation = {
 
 // Detects if the auth key used is crypto v1 or v2
 // Detects if the SF_CRYPTO_V2 env var is set and if it matches the key crypto version
+// eslint-disable-next-line complexity
 const cryptoVersionTest = async (doctor: SfDoctor): Promise<void> => {
   getLogger().debug('Running Crypto Version tests');
 
@@ -164,6 +165,7 @@ const cryptoVersionTest = async (doctor: SfDoctor): Promise<void> => {
 
 // Inspect CLI install and plugins to ensure all versions of `@salesforce/core` can support v2 crypto.
 // This uses `npm explain @salesforce/core` to ensure all versions are greater than 6.6.0.
+// eslint-disable-next-line complexity
 const supportsCliV2Crypto = async (doctor: SfDoctor): Promise<boolean> => {
   const diagnosis: SfDoctorDiagnosis = doctor.getDiagnosis();
   let coreSupportsV2 = false;

src/commands/org/login/web.ts

@@ -205,7 +205,7 @@ describe('org:login:jwt', () => {
     await prepareStubs({ existingAuth: true });
     try {
       await LoginJwt.run(['-u', testData.username, '-f', 'path/to/key.json', '-i', '123456', '--json']);
-    } catch (e) {
+    } catch (_e) {
       expect.fail('Should not have thrown an error');
     }
   });