apply suggestions

Author: thongdk8

charts/scalar-manager/templates/scalar-manager/certmanager.yaml

@@ -88,6 +88,9 @@ spec:
       {{- end }}
     kind: Issuer
     {{- else }}
-    {{- toYaml .Values.scalarManager.tls.certManager.issuerRef | nindent 4 }}
+      {{- if not (len .Values.scalarManager.tls.certManager.issuerRef) }}
+        {{- fail "When using cert-manager with an external issuer, scalarManager.tls.certManager.issuerRef must be configured." -}}
+      {{- end }}
+      {{- toYaml .Values.scalarManager.tls.certManager.issuerRef | nindent 4 }}
     {{- end }}
 {{- end }}

charts/scalar-manager/templates/scalar-manager/deployment.yaml

@@ -188,6 +188,11 @@ spec:
                     - key: tls.key
                       path: tls.key
         {{- end }}
+        {{- if and .Values.scalarManager.tls.downstream.enabled (not .Values.scalarManager.tls.certManager.enabled) }}
+          {{- if or (not .Values.scalarManager.tls.downstream.certChainSecret) (not .Values.scalarManager.tls.downstream.privateKeySecret) }}
+            {{- fail "When using manual downstream TLS, both scalarManager.tls.downstream.certChainSecret and scalarManager.tls.downstream.privateKeySecret must be set." -}}
+          {{- end }}
+        {{- end -}}
         {{- if and .Values.scalarManager.tls.downstream.enabled .Values.scalarManager.tls.certManager.enabled }}
         - name: scalar-manager-tls-volume
           secret: