Merge pull request #187 from jtherin/fixincorrectfilter

jtherin · web-flow · commit ccf654a502e3 · 2025-10-01T11:14:48.000+02:00
fix(lb): do not block lb if filtered nodes are good
diff --git a/scaleway/loadbalancers.go b/scaleway/loadbalancers.go
@@ -584,11 +584,11 @@ func (l *loadbalancers) updateLoadBalancer(ctx context.Context, loadbalancer *sc
 		return fmt.Errorf("invalid value for annotation %s: expected boolean", serviceAnnotationLoadBalancerExternallyManaged)
 	}
 
+	nodes = filterNodes(service, nodes)
 	if err := nodesInitialized(nodes); err != nil {
 		return err
 	}
 
-	nodes = filterNodes(service, nodes)
 	if l.pnID != "" {
 		respPN, err := l.api.ListLBPrivateNetworks(&scwlb.ZonedAPIListLBPrivateNetworksRequest{
 			Zone: loadbalancer.Zone,

Original file line number	Diff line number	Diff line change
`@@ -584,11 +584,11 @@ func (l loadbalancers) updateLoadBalancer(ctx context.Context, loadbalancer sc`
`584`	`584`	`return fmt.Errorf("invalid value for annotation %s: expected boolean", serviceAnnotationLoadBalancerExternallyManaged)`
`585`	`585`	`}`
`586`	`586`
	`587`	`+ nodes = filterNodes(service, nodes)`
`587`	`588`	`if err := nodesInitialized(nodes); err != nil {`
`588`	`589`	`return err`
`589`	`590`	`}`
`590`	`591`
`591`		`- nodes = filterNodes(service, nodes)`
`592`	`592`	`if l.pnID != "" {`
`593`	`593`	`respPN, err := l.api.ListLBPrivateNetworks(&scwlb.ZonedAPIListLBPrivateNetworksRequest{`
`594`	`594`	`Zone: loadbalancer.Zone,`