fix(domain): correctly check for NoSuchDNSZone error code (#1812)

ndrpnt · web-flow · commit 98aad59db336 · 2023-03-06T10:30:44.000Z
diff --git a/scaleway/resource_domain_record.go b/scaleway/resource_domain_record.go
@@ -504,7 +504,7 @@ func resourceScalewayDomainRecordDelete(ctx context.Context, d *schema.ResourceD
 	d.SetId("")
 
 	_, err = waitForDNSZone(ctx, domainAPI, d.Get("dns_zone").(string), d.Timeout(schema.TimeoutDelete))
-	if err != nil && !ErrCodeEquals(err, domain.ErrCodeNoSuchDNSZone) {
+	if err != nil && !errorCheck(err, domain.ErrCodeNoSuchDNSZone) {
 		if is404Error(err) || is403Error(err) {
 			return nil
 		}

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,7 @@ func resourceScalewayDomainRecordDelete(ctx context.Context, d *schema.ResourceD`
`504`	`504`	`d.SetId("")`
`505`	`505`
`506`	`506`	`_, err = waitForDNSZone(ctx, domainAPI, d.Get("dns_zone").(string), d.Timeout(schema.TimeoutDelete))`
`507`		`- if err != nil && !ErrCodeEquals(err, domain.ErrCodeNoSuchDNSZone) {`
	`507`	`+ if err != nil && !errorCheck(err, domain.ErrCodeNoSuchDNSZone) {`
`508`	`508`	`if is404Error(err) \|\| is403Error(err) {`
`509`	`509`	`return nil`
`510`	`510`	`}`