fix(resource_instance_server): delete on termination defaut value (#758)

Author: kindermoumoute

scaleway/resource_instance_server.go

@@ -453,7 +453,8 @@ func resourceScalewayInstanceServerRead(ctx context.Context, d *schema.ResourceD
 
 			rootVolume["volume_id"] = newZonedID(zone, volume.ID).String()
 			rootVolume["size_in_gb"] = int(uint64(volume.Size) / gb)
-			rootVolume["delete_on_termination"] = d.Get("root_volume.0.delete_on_termination")
+			_, rootVolumeAttributeSet := d.GetOk("root_volume") // Related to https://github.com/hashicorp/terraform-plugin-sdk/issues/142
+			rootVolume["delete_on_termination"] = d.Get("root_volume.0.delete_on_termination").(bool) || !rootVolumeAttributeSet
 
 			_ = d.Set("root_volume", []map[string]interface{}{rootVolume})
 		} else {
@@ -714,7 +715,9 @@ func resourceScalewayInstanceServerDelete(ctx context.Context, d *schema.Resourc
 		return diag.FromErr(err)
 	}
 
-	if d.Get("root_volume.0.delete_on_termination").(bool) {
+	// Related to https://github.com/hashicorp/terraform-plugin-sdk/issues/142
+	_, rootVolumeAttributeSet := d.GetOk("root_volume")
+	if d.Get("root_volume.0.delete_on_termination").(bool) || !rootVolumeAttributeSet {
 		err = instanceAPI.DeleteVolume(&instance.DeleteVolumeRequest{
 			Zone:     zone,
 			VolumeID: expandZonedID(d.Get("root_volume.0.volume_id")).ID,

scaleway/resource_instance_server_test.go

@@ -59,7 +59,6 @@ func TestAccScalewayInstanceServer_Minimal1(t *testing.T) {
 		CheckDestroy:      testAccCheckScalewayInstanceServerDestroy(tt),
 		Steps: []resource.TestStep{
 			{
-				// Image id such as f974feac-abae-4365-b988-8ec7d1cec10d
 				Config: `
 					resource "scaleway_instance_server" "base" {
 					  image = "ubuntu_focal"