Skip to content

FEAT - Add score to GeneralizedLinearEstimator based on its datafit #254

@mathurinm

Description

@mathurinm

A datafit can implement a score (based on its use for classif or regression) and this score can be accessed by GeneralizedLinearEstimator.score()

This would be one more step towards sklearn-like behavior

I think this should be done with Mixins:

  • define ClassificationDatafitMixin, RegressionDatafitMixin that have their own score()
  • All datafits inherit from one or the other
  • GeneralizedLinearModel.score calls self.datafit.score()

As a cherry on top this would enable us to replace the hardcoded isclassif in _glm_fit, that currently checks if a datafit is for classif by checking if it's equal to Logistic or QuadraticSVC.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions