From bd1bfd05ca85cef52b1443cde9d2caad8605c24c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A1n=20Chaves?= Date: Wed, 27 Nov 2019 10:36:32 +0100 Subject: [PATCH] Test cookie.path_specified == False --- scrapy_splash/cookies.py | 2 +- tests/test_cookies.py | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/scrapy_splash/cookies.py b/scrapy_splash/cookies.py index fcbdb6d..afcd06c 100644 --- a/scrapy_splash/cookies.py +++ b/scrapy_splash/cookies.py @@ -83,7 +83,7 @@ def har_to_cookie(har_cookie): value=har_cookie['value'], port=None, domain=har_cookie.get('domain', ''), - path=har_cookie.get('path', '/'), + path=har_cookie.get('path', ''), secure=har_cookie.get('secure', False), expires=expires_timestamp, discard=False, diff --git a/tests/test_cookies.py b/tests/test_cookies.py index f5be043..b205002 100644 --- a/tests/test_cookies.py +++ b/tests/test_cookies.py @@ -18,3 +18,14 @@ def test_cookie_to_har(): assert cookie_to_har(har_to_cookie(har_cookie)) == har_cookie cookie = har_to_cookie(har_cookie) assert vars(cookie) == vars(har_to_cookie(cookie_to_har(cookie))) + + +def test_cookie_to_har_minimum_data(): + har_cookie = { + "name": "TestCookie", + "value": "Cookie Value", + "secure": True, + } + assert cookie_to_har(har_to_cookie(har_cookie)) == har_cookie + cookie = har_to_cookie(har_cookie) + assert vars(cookie) == vars(har_to_cookie(cookie_to_har(cookie)))