From eec72df755935305d431f9b12bfd80280cd5c498 Mon Sep 17 00:00:00 2001
From: dbe <davidbrianethier@gmail.com>
Date: Tue, 24 Apr 2018 18:42:00 -0600
Subject: [PATCH] Pulling post request outside of file.forEach

---
 tasks/screeps.js | 99 ++++++++++++++++++++++++------------------------
 1 file changed, 49 insertions(+), 50 deletions(-)

diff --git a/tasks/screeps.js b/tasks/screeps.js
index cff9ed8..922c2f7 100644
--- a/tasks/screeps.js
+++ b/tasks/screeps.js
@@ -51,63 +51,62 @@ module.exports = function (grunt) {
                     modules[name] = {binary: grunt.file.read(filepath, {encoding: null}).toString('base64')};
                 }
             });
+        });
 
-            var proto = server.http ? http : https,
-                req = proto.request({
-                hostname: server.host || 'screeps.com',
-                port: server.port || (server.http ? 80 : 443),
-                path: options.ptr ? '/ptr/api/user/code' : '/api/user/code',
-                method: 'POST',
-                auth: options.email + ':' + options.password,
-                headers: {
-                    'Content-Type': 'application/json; charset=utf-8'
-                }
-            }, function(res) {
-                res.setEncoding('utf8');
+        var proto = server.http ? http : https;
+        var req = proto.request({
+            hostname: server.host || 'screeps.com',
+            port: server.port || (server.http ? 80 : 443),
+            path: options.ptr ? '/ptr/api/user/code' : '/api/user/code',
+            method: 'POST',
+            auth: options.email + ':' + options.password,
+            headers: {
+                'Content-Type': 'application/json; charset=utf-8'
+            }
+        }, function(res) {
+            res.setEncoding('utf8');
 
-                var data = '';
+            var data = '';
 
-                if(res.statusCode < 200 || res.statusCode >= 300) {
-                  grunt.fail.fatal('Screeps server returned error code ' + res.statusCode);
-                }
+            if(res.statusCode < 200 || res.statusCode >= 300) {
+              grunt.fail.fatal('Screeps server returned error code ' + res.statusCode);
+            }
+
+            res.on('data', function(chunk) {
+                data += chunk;
+            });
 
-                res.on('data', function(chunk) {
-                    data += chunk;
-                });
-
-                res.on('end', function() {
-                    var serverText = server && server.host || 'Screeps';
-                    try {
-                      var parsed = JSON.parse(data);
-                      serverText = server && server.host || 'Screeps';
-                      if(parsed.ok) {
-                          var msg = 'Committed to ' + serverText + ' account "' + options.email + '"';
-                          if(options.branch) {
-                              msg += ' branch "' + options.branch+'"';
-                          }
-                          if(options.ptr) {
-                              msg += ' [PTR]';
-                          }
-                          msg += '.';
-                          grunt.log.writeln(msg);
+            res.on('end', function() {
+                var serverText = server && server.host || 'Screeps';
+                try {
+                  var parsed = JSON.parse(data);
+                  serverText = server && server.host || 'Screeps';
+                  if(parsed.ok) {
+                      var msg = 'Committed to ' + serverText + ' account "' + options.email + '"';
+                      if(options.branch) {
+                          msg += ' branch "' + options.branch+'"';
                       }
-                      else {
-                          grunt.log.error('Error while committing to ' + serverText + ': '+util.inspect(parsed));
+                      if(options.ptr) {
+                          msg += ' [PTR]';
                       }
-                    } catch (e) {
-                      grunt.log.error('Error while processing ' + serverText + ' json: '+e.message);
-                    }
-                    done();
-                });
+                      msg += '.';
+                      grunt.log.writeln(msg);
+                  }
+                  else {
+                      grunt.log.error('Error while committing to ' + serverText + ': '+util.inspect(parsed));
+                  }
+                } catch (e) {
+                  grunt.log.error('Error while processing ' + serverText + ' json: '+e.message);
+                }
+                done();
             });
-
-            var postData = {modules: modules};
-            if(options.branch) {
-                postData.branch = options.branch;
-            }
-            req.write(JSON.stringify(postData));
-            req.end();
         });
-    });
 
+        var postData = {modules: modules};
+        if(options.branch) {
+            postData.branch = options.branch;
+        }
+        req.write(JSON.stringify(postData));
+        req.end();
+    });
 };