feat: Merge pull request #58 from seamapi/add-new-params-nov-14

Author: razor-x

seamapi/connect_webviews.py

@@ -30,7 +30,7 @@ class ConnectWebviews(AbstractConnectWebviews):
     get(connect_webview)
         Gets a connect webview
     create(
-      accepted_providers, custom_redirect_url=None, device_selection_mode==None
+      accepted_providers, custom_redirect_url=None, custom_redirect_failure_url=None, device_selection_mode=None
     )
         Creates a connect webview
     """
@@ -107,6 +107,7 @@ def create(
         self,
         accepted_providers: List[AcceptedProvider],
         custom_redirect_url: Optional[str] = None,
+        custom_redirect_failure_url: Optional[str] = None,
         device_selection_mode: Optional[str] = None,
     ) -> ConnectWebview:
         """Creates a connect webview.
@@ -117,6 +118,8 @@ def create(
             A list of accepted providers e.g. august or noiseaware
         custom_redirect_url : str, optional
             Custom redirect url
+        custom_redirect_failure_url : str, optional
+            Custom redirect failure url
         device_selection_mode : str, optional
             Selection mode: 'none', 'single' or 'multiple'
 
@@ -133,6 +136,8 @@ def create(
         create_payload = {"accepted_providers": accepted_providers}
         if custom_redirect_url is not None:
             create_payload["custom_redirect_url"] = custom_redirect_url
+        if custom_redirect_failure_url is not None:
+            create_payload["custom_redirect_failure_url"] = custom_redirect_failure_url
         if device_selection_mode is not None:
             create_payload["device_selection_mode"] = device_selection_mode
 

seamapi/devices.py

@@ -32,7 +32,7 @@ class Devices(AbstractDevices):
 
     Methods
     -------
-    list(connected_account=None, connect_webview=None, device_type=None)
+    list(connected_account=None, connect_webview=None, device_type=None, device_ids=None)
         Gets a list of devices
     get(device=None, name=None)
         Gets a device
@@ -58,6 +58,7 @@ def list(
         connected_account: Union[ConnectedAccountId, ConnectedAccount] = None,
         connect_webview: Union[ConnectWebviewId, ConnectWebview] = None,
         device_type: Optional[DeviceType] = None,
+        device_ids: Optional[list] = None,
     ) -> List[Device]:
         """Gets a list of devices.
 
@@ -69,6 +70,8 @@ def list(
             Connect webview id or ConnectWebview to get devices associated with
         device_type : DeviceType, optional
             Device type e.g. august_lock
+        device_ids : Optional[list]
+            Device IDs to filter devices by
 
         Raises
         ------
@@ -91,6 +94,8 @@ def list(
             )
         if device_type:
             params["device_type"] = device_type
+        if device_ids is not None:
+            params["device_ids"] =  [to_device_id(d) for d in device_ids]
 
         res = self.seam.make_request(
             "GET",

seamapi/types.py

@@ -115,6 +115,7 @@ class ConnectWebview:
     connected_account_id: Optional[str] = None
     authorized_at: Optional[str] = None
     custom_redirect_url: Optional[str] = None
+    custom_redirect_failure_url: Optional[str] = None
     accepted_providers: Optional[List[AcceptedProvider]] = None
     accepted_devices: Optional[List[str]] = None
 

tests/access_codes/test_access_codes.py

@@ -1,5 +1,5 @@
 from seamapi import Seam
-from seamapi.types import ActionAttemptFailedException
+from seamapi.types import SeamAPIException
 from tests.fixtures.run_august_factory import run_august_factory
 import pytest
 
@@ -21,7 +21,7 @@ def test_access_codes(seam: Seam):
     access_code = seam.access_codes.get(created_access_code.access_code_id)
     assert access_code.code == "4444"
 
-    with pytest.raises(ActionAttemptFailedException):
+    with pytest.raises(SeamAPIException):
         seam.access_codes.create(some_device.device_id, "Duplicate Access Code", "4444")
 
     access_code = seam.access_codes.update(access_code, name="Updated name")

tests/devices/test_devices.py

@@ -10,6 +10,10 @@ def test_devices(seam: Seam):
     devices = seam.devices.list()
     assert len(devices) > 0
 
+    device_ids = [devices[0]]
+    devices = seam.devices.list(device_ids=device_ids)
+    assert len(devices) == 1
+
     some_device = seam.devices.get(name="Generated Lock 0")
     assert some_device.properties.name == "Generated Lock 0"