Use 'pipefail' feature

In order to determine if a command in a command pipeline failed the
'set -o pipefail' option has to be set. Sadly not all shells support it.
But the most public ones do and since nothing breaks if it is not
available we should be fine using it.

Issue #180

Author: sebastianfeldmann

composer.json

@@ -41,7 +41,7 @@
     "ext-json": "*",
     "ext-spl": "*",
     "sebastian/environment": "~1.1|~2.0|~3.0|~4.0",
-    "sebastianfeldmann/cli": "~2.0",
+    "sebastianfeldmann/cli": "~2.2",
     "phpmailer/phpmailer": "~6.0",
     "symfony/event-dispatcher": "~2.6|~3.0|~4.0"
   },

src/Cli/Executable/Abstraction.php

@@ -64,7 +64,10 @@ protected function setup(string $cmd, string $path = '')
      */
     public function getCommandLine() : CommandLine
     {
-        return $this->createCommandLine();
+        $process = $this->createCommandLine();
+        $process->pipeFail(true);
+
+        return $process;
     }
 
     /**

tests/phpbu/Backup/Source/MysqldumpTest.php

@@ -65,7 +65,9 @@ public function testPipeCompression()
         $executable = $mysqldump->getExecutable($target);
 
         $this->assertEquals(
-            PHPBU_TEST_BIN . '/mysqldump --all-databases | ' . PHPBU_TEST_BIN . '/gzip > /tmp/foo.sql.gz',
+            'set -o pipefail; '
+            . PHPBU_TEST_BIN . '/mysqldump --all-databases | '
+            . PHPBU_TEST_BIN . '/gzip > /tmp/foo.sql.gz',
             $executable->getCommand()
         );
     }

tests/phpbu/Backup/Source/TarTest.php

@@ -182,7 +182,8 @@ public function testThrottle()
         $exec = $tar->getExecutable($target);
 
         $this->assertEquals(
-            PHPBU_TEST_BIN . '/tar -c -C \''
+            'set -o pipefail; '
+            . PHPBU_TEST_BIN . '/tar -c -C \''
             . dirname(__DIR__) . '\' \''
             . basename(__DIR__) . '\''
             . ' | pv -qL \'1m\' > /tmp/backup.tar',

tests/phpbu/Cli/Executable/MysqldumpTest.php

@@ -252,7 +252,7 @@ public function testCompressor()
         $mysqldump->compressOutput($compression)->dumpTo('/tmp/foo.mysql');
 
         $this->assertEquals(
-            $path . '/mysqldump --all-databases | ' . $path . '/gzip > /tmp/foo.mysql.gz',
+            'set -o pipefail; ' . $path . '/mysqldump --all-databases | ' . $path . '/gzip > /tmp/foo.mysql.gz',
             $mysqldump->getCommand()
         );
     }

tests/phpbu/Cli/Executable/TarTest.php

@@ -169,8 +169,9 @@ public function testThrottle()
             ->throttle('1m');
 
         $this->assertEquals(
-            PHPBU_TEST_BIN . '/tar -jc -C \'' . $tarC .  '\' \'' . $tarD . '\'' .
-            ' | pv -qL \'1m\' > /tmp/foo.tar.bzip2',
+            'set -o pipefail; '
+            . PHPBU_TEST_BIN . '/tar -jc -C \'' . $tarC .  '\' \'' . $tarD . '\''
+            . ' | pv -qL \'1m\' > /tmp/foo.tar.bzip2',
             $tar->getCommand()
         );
     }
@@ -191,7 +192,8 @@ public function testThrottleAndRemoveSourceDir()
             ->throttle('1m');
 
         $this->assertEquals(
-            '(' . PHPBU_TEST_BIN . '/tar -jc -C \'' . $tarC .  '\' \'' . $tarD . '\''
+            'set -o pipefail; '
+            . '(' . PHPBU_TEST_BIN . '/tar -jc -C \'' . $tarC .  '\' \'' . $tarD . '\''
             . ' && rm -rf \'' . $dir . '\')'
             . ' | pv -qL \'1m\' > /tmp/foo.tar.bzip2',
             $tar->getCommand()