Skip to content

Commit a233e04

Browse files
Fix smime encryption option
The openssl smime doesn't use -e and -d instead it uses -encrypt and -decrypt. Fixes issue #221
1 parent cecf062 commit a233e04

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/Cli/Executable/OpenSSL.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ protected function setOptions(Cmd $cmd): void
336336
protected function setCertOptions(Cmd $cmd): void
337337
{
338338
$cmd->addOption('smime');
339-
$cmd->addOption('-' . $this->action);
339+
$cmd->addOption('-' . ($this->action === 'e' ? 'encrypt' : 'decrypt'));
340340
$cmd->addOption('-' . $this->algorithm);
341341
$cmd->addOption('-binary');
342342
$cmd->addOption('-in', $this->sourceFile, ' ');

tests/phpbu/Backup/Crypter/OpenSSLTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public function testCertFile()
8383
$openSSL->setup(['pathToOpenSSL' => PHPBU_TEST_BIN, 'certFile' => '/foo/my.pem', 'algorithm' => 'aes256']);
8484

8585
$executable = $openSSL->getExecutable($target);
86-
$expected = '(' . PHPBU_TEST_BIN . '/openssl smime -e -aes256 -binary -in \'/foo/bar.txt\' '
86+
$expected = '(' . PHPBU_TEST_BIN . '/openssl smime -encrypt -aes256 -binary -in \'/foo/bar.txt\' '
8787
. '-out \'/foo/bar.txt.enc\' -outform DER \'/foo/my.pem\' '
8888
. '&& rm \'/foo/bar.txt\')';
8989

tests/phpbu/Cli/Executable/OpenSSLTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public function testDoNotDeleteUncrypted()
101101
*/
102102
public function testCert()
103103
{
104-
$expected = 'openssl smime -e -aes256 -binary -in \'/foo/bar.txt\' '
104+
$expected = 'openssl smime -encrypt -aes256 -binary -in \'/foo/bar.txt\' '
105105
. '-out \'/foo/bar.txt.enc\' -outform DER \'/foo/my.pem\' '
106106
. '&& rm \'/foo/bar.txt\'';
107107
$openSSL = new OpenSSL(PHPBU_TEST_BIN);

0 commit comments

Comments
 (0)