Fix deprecations

Author: sebastianfeldmann

src/Backup/Sync/AmazonS3v3.php

@@ -69,7 +69,7 @@ public function sync(Target $target, Result $result)
             // run remote cleanup
             $this->cleanup($target, $result);
         } catch (\Exception $e) {
-            throw new Exception($e->getMessage(), null, $e);
+            throw new Exception($e->getMessage(), 0, $e);
         }
     }
 
@@ -95,7 +95,7 @@ protected function createClient() : S3Client
         if ($this->signatureVersion) {
             $config['signature_version'] = $this->signatureVersion;
         }
-        
+
         return new S3Client($config);
     }
 

src/Backup/Sync/AzureBlob.php

@@ -134,7 +134,7 @@ public function sync(Target $target, Result $result)
             // run remote cleanup
             $this->cleanup($target, $result);
         } catch (\Exception $e) {
-            throw new Exception($e->getMessage(), null, $e);
+            throw new Exception($e->getMessage(), 0, $e);
         }
     }
 

src/Backup/Sync/Dropbox.php

@@ -124,7 +124,7 @@ public function sync(Target $target, Result $result)
             // run remote cleanup
             $this->cleanup($target, $result);
         } catch (\Exception $e) {
-            throw new Exception($e->getMessage(), null, $e);
+            throw new Exception($e->getMessage(), 0, $e);
         }
     }
 

src/Backup/Sync/GoogleDrive.php

@@ -143,7 +143,7 @@ public function sync(Target $target, Result $result)
             $result->debug(sprintf('upload: done: %s', $apiResult->getId()));
             $this->cleanup($target, $result);
         } catch (\Exception $e) {
-            throw new Exception($e->getMessage(), null, $e);
+            throw new Exception($e->getMessage(), 0, $e);
         }
     }
 

src/Backup/Sync/YandexDisk.php

@@ -112,7 +112,7 @@ public function sync(Target $target, Result $result): void
             }
             $this->cleanup($target, $result);
         } catch (\Exception $e) {
-            throw new Exception($e->getMessage(), null, $e);
+            throw new Exception($e->getMessage(), 0, $e);
         }
     }
 

src/Util/Cli.php

@@ -139,7 +139,7 @@ public static function detectCmdLocationWithWhich(string $cmd) : string
         $bin = '';
         // on nx systems use 'which' command.
         if (!defined('PHP_WINDOWS_VERSION_BUILD')) {
-            $command = trim(`which $cmd`);
+            $command = trim((string) `which $cmd`);
             $bin     = self::isExecutable($command);
         }
         return $bin;

src/Util/Str.php

@@ -28,9 +28,9 @@ public static function toBoolean($value, $default) : bool
         if (is_bool($value)) {
             return $value;
         }
-        if (strtolower($value) == 'false') {
+        if (strtolower((string)$value) == 'false') {
             return false;
-        } elseif (strtolower($value) == 'true') {
+        } elseif (strtolower((string)$value) == 'true') {
             return true;
         }
         return $default;

tests/phpbu/Log/ResultFormatter/FormDataTest.php

@@ -1,6 +1,9 @@
 <?php
 namespace phpbu\App\Log\ResultFormatter;
 
+use Exception;
+use phpbu\App\Result;
+use phpbu\App\Result\Backup;
 use function GuzzleHttp\Psr7\parse_query;
 use PHPUnit\Framework\TestCase;
 
@@ -25,7 +28,8 @@ public function testFormat()
         $result      = $this->getResultMock();
         $formatter   = new FormData();
         $queryString = $formatter->format($result);
-        $rawData     = parse_query($queryString);
+        $rawData     = [];
+        parse_str($queryString, $rawData);
 
         $this->assertNotEmpty($queryString);
         $this->assertEquals(0, $rawData['status']);
@@ -39,12 +43,12 @@ public function testFormat()
      */
     protected function getResultMock()
     {
-        $result = $this->createMock(\phpbu\App\Result::class);
+        $result = $this->createMock(Result::class);
         $result->expects($this->once())->method('started')->willReturn(microtime(true));
         $result->expects($this->once())->method('allOk')->willReturn(true);
         $result->expects($this->once())->method('backupsFailedCount')->willReturn(0);
         $result->expects($this->once())->method('errorCount')->willReturn(1);
-        $result->expects($this->once())->method('getErrors')->willReturn([new \Exception('foo bar')]);
+        $result->expects($this->once())->method('getErrors')->willReturn([new Exception('foo bar')]);
         $result->expects($this->once())->method('getBackups')->willReturn([$this->getBackupResultMock()]);
 
         return $result;
@@ -57,7 +61,7 @@ protected function getResultMock()
      */
     protected function getBackupResultMock()
     {
-        $backup = $this->createMock(\phpbu\App\Result\Backup::class);
+        $backup = $this->createMock(Backup::class);
         $backup->method('getName')->willReturn('foo');
         $backup->method('allOk')->willReturn(true);
         $backup->method('checkCount')->willReturn(0);